rules: Refactoring and minor improvements

Compared to the previous commit, the action graphs for just
and its unit tests are unchanged.
- Git hash of action graph for ["",""]:
    c6e75f17abd7ffaab6ff9bb725ad67ec0bf6c973
- Git hash of action graph for ["test/buildtool","TESTS"]:
    8063dfb3dd7daa9ae01d95c177e14946f785c57e

Refactor:
- "local cflags" to "private-cflags"
- "local defines" to "private-defines"
- "link externals" to "private-ldflags"
- "deps" to "private-deps" for (test) binaries
- "proto" to "private-proto" for binaries

Improvements:
- consistent variable declaration order:
    OS, ARCH, HOST_ARCH, TARGET_ARCH,
    CC, CXX, CFLAGS, CXXFLAGS, ADD_CFLAGS, ADD_CXXFLAGS,
    AR, ENV, PATH
- use fields close to their definition (in RULES)
- use common expression for binaries and test binaries
- split expression "flags" and "compiler"
  ... to separate ones for CC and CXX.
- rename "transition" to "deps-transition"
  ... to avoid conflicts with other transitions.
- support "defaults-transition" for CC expressions

Implement:
- "cflags" for libraries
- "private-cflags" for (test) binaries
- "private-defines" for test binaries
- "private-ldflags" for test binaries
- (public) "defines" for libraries

1 files changed, 1 insertions, 1 deletions

diff --git a/bin/bootstrap.py b/bin/bootstrap.py
index f07b66af..a8030e12 100755
--- a/bin/bootstrap.py
+++ b/bin/bootstrap.py
@@ -231,7 +231,7 @@ def config_to_local(*, repos_file, link_targets_file):
     link_external = ["-L%s" % (os.path.join(LOCALBASE, d),)
                      for d in global_link_dirs]
     print("External link arguments %r" % (link_external,))
-    main["link external"] = link_external
+    main["private-ldflags"] = link_external
     target[LOCAL_LINK_DIRS_TARGET] = main
     os.unlink(link_targets_file)
     with open(link_targets_file, "w") as f: