summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorKlaus Aehlig <klaus.aehlig@huawei.com>2024-10-28 12:18:44 +0100
committerKlaus Aehlig <klaus.aehlig@huawei.com>2024-10-28 13:56:46 +0100
commit70893762d10b25cdba70d72b78a640bdb29c0dcd (patch)
tree298298161bc8596cf7548da7d56b0a5fb49a1053 /src
parent0c1e4bdebd705bde7c8a03b671c31dcd354aebcd (diff)
downloadjustbuild-70893762d10b25cdba70d72b78a640bdb29c0dcd.tar.gz
BatchUploadBlobs: decrease log level for retried tasks
In BatchUploadBlobs we accept short writes and, in case of no progress, fall back to single blob upload. Therefore, failure to upload blobs is not fatal and therefore should not be reported at error level. Decrease the log level accordingly: a protocol failure to upload is a performance-related event (as the retry needs additional time), catching an internal exception is something that shouldn't really happen, so we warn the user.
Diffstat (limited to 'src')
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp
index 54654233..fa299187 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp
@@ -542,12 +542,14 @@ auto BazelCasClient::BatchUpdateBlobs(
return batch_update_blobs(request);
},
retry_config_,
- logger_);
+ logger_,
+ LogLevel::Performance);
})) {
- logger_.Emit(LogLevel::Error, "Failed to BatchUpdateBlobs.");
+ logger_.Emit(LogLevel::Performance, "Failed to BatchUpdateBlobs.");
}
} catch (...) {
- logger_.Emit(LogLevel::Error, "Caught exception in DoBatchUpdateBlobs");
+ logger_.Emit(LogLevel::Warning,
+ "Caught exception in DoBatchUpdateBlobs");
}
logger_.Emit(LogLevel::Trace, [begin, end, &result]() {
std::ostringstream oss{};