diff options
| author | Maksim Denisov <denisov.maksim@huawei.com> | 2024-09-18 17:51:41 +0200 |
|---|---|---|
| committer | Maksim Denisov <denisov.maksim@huawei.com> | 2024-09-23 10:54:50 +0200 |
| commit | dc1db0e8b43f5e907a3ded2e39da8b58fa50a04b (patch) | |
| tree | 7ca1dd20806fd71c42f875adc1c653df45b147b1 /test/buildtool/file_system/object_cas.test.cpp | |
| parent | 6453a846e788887b6cd74d71c1873a5e3270434d (diff) | |
| download | justbuild-dc1db0e8b43f5e907a3ded2e39da8b58fa50a04b.tar.gz | |
Store HashFunction by const reference.
Despite the fact that HashFunction is a small type, it still makes sense to store it by reference to reflect the ownership. StorageConfig becomes the main holder.
Reference holders store HashFunction by const ref and aren't allowed to change it. However, they are free to return HashFunction by value since this doesn't benefit readability anyhow.
Diffstat (limited to 'test/buildtool/file_system/object_cas.test.cpp')
| -rw-r--r-- | test/buildtool/file_system/object_cas.test.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/buildtool/file_system/object_cas.test.cpp b/test/buildtool/file_system/object_cas.test.cpp index 6f06eea4..1872f25b 100644 --- a/test/buildtool/file_system/object_cas.test.cpp +++ b/test/buildtool/file_system/object_cas.test.cpp @@ -34,7 +34,7 @@ TEST_CASE("ObjectCAS", "[file_system]") { storage_config.Get().hash_function, test_content); SECTION("CAS for files") { - ObjectCAS<ObjectType::File> cas{storage_config.Get().hash_function, + ObjectCAS<ObjectType::File> cas{&storage_config.Get().hash_function, gen_config.cas_f}; CHECK(not cas.BlobPath(test_digest)); @@ -74,7 +74,7 @@ TEST_CASE("ObjectCAS", "[file_system]") { SECTION("CAS for executables") { ObjectCAS<ObjectType::Executable> cas{ - storage_config.Get().hash_function, gen_config.cas_x}; + &storage_config.Get().hash_function, gen_config.cas_x}; CHECK(not cas.BlobPath(test_digest)); SECTION("Add blob from bytes and verify") { |