memcheck: fix race in libgit2...

...caused by incorrectly setting and resetting the library internal
state and the misuse of pthreads in libgit2.

Normally, git_libgit2_init and git_libgit2_shutdown should span the
life of a worker thread in order to be safely used. However, due to
an incorrect implementation of libgit2's threadstate with pthreads,
on unix systems there is a race condition.

Until the use of pthread_key_t is corrected in libgit2, we need to
apply a workaround by always ensuring that the main thread is the
first thread reaching the GitContext constructor.

1 files changed, 10 insertions, 0 deletions

diff --git a/test/main.cpp b/test/main.cpp
index c93583f2..bb431de2 100644
--- a/test/main.cpp
+++ b/test/main.cpp
@@ -13,9 +13,19 @@
 // limitations under the License.
 
 #include "catch2/catch_session.hpp"
+#include "src/buildtool/file_system/git_context.hpp"
 #include "test/utils/logging/log_config.hpp"
 
 auto main(int argc, char* argv[]) -> int {
     ConfigureLogging();
+
+    /**
+     * The current implementation of libgit2 uses pthread_key_t incorrectly
+     * on POSIX systems to handle thread-specific data, which requires us to
+     * explicitly make sure the main thread is the first one to call
+     * git_libgit2_init. Future versions of libgit2 will hopefully fix this.
+     */
+    GitContext::Create();
+
     return Catch::Session().run(argc, argv);
 }