diff options
author | Oliver Reiche <oliver.reiche@huawei.com> | 2022-12-02 15:33:03 +0100 |
---|---|---|
committer | Oliver Reiche <oliver.reiche@huawei.com> | 2022-12-09 13:13:21 +0100 |
commit | 7d260287328a38fbc1430bed56cbdaeaebd58efd (patch) | |
tree | c5a94ec2ad2585ce3f592797104af2a9e6e32f80 /test/utils/cpp | |
parent | 62d155accb047ade3d5a7a89b643e286b333ba41 (diff) | |
download | justbuild-7d260287328a38fbc1430bed56cbdaeaebd58efd.tar.gz |
rules: Refactoring and minor improvements
Compared to the previous commit, the action graphs for just
and its unit tests are unchanged.
- Git hash of action graph for ["",""]:
c6e75f17abd7ffaab6ff9bb725ad67ec0bf6c973
- Git hash of action graph for ["test/buildtool","TESTS"]:
8063dfb3dd7daa9ae01d95c177e14946f785c57e
Refactor:
- "local cflags" to "private-cflags"
- "local defines" to "private-defines"
- "link externals" to "private-ldflags"
- "deps" to "private-deps" for (test) binaries
- "proto" to "private-proto" for binaries
Improvements:
- consistent variable declaration order:
OS, ARCH, HOST_ARCH, TARGET_ARCH,
CC, CXX, CFLAGS, CXXFLAGS, ADD_CFLAGS, ADD_CXXFLAGS,
AR, ENV, PATH
- use fields close to their definition (in RULES)
- use common expression for binaries and test binaries
- split expression "flags" and "compiler"
... to separate ones for CC and CXX.
- rename "transition" to "deps-transition"
... to avoid conflicts with other transitions.
- support "defaults-transition" for CC expressions
Implement:
- "cflags" for libraries
- "private-cflags" for (test) binaries
- "private-defines" for test binaries
- "private-ldflags" for test binaries
- (public) "defines" for libraries
Diffstat (limited to 'test/utils/cpp')
-rw-r--r-- | test/utils/cpp/TARGETS | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/utils/cpp/TARGETS b/test/utils/cpp/TARGETS index 5e11d258..113d6d10 100644 --- a/test/utils/cpp/TARGETS +++ b/test/utils/cpp/TARGETS @@ -2,7 +2,7 @@ { "type": ["@", "rules", "CC/test", "test"] , "name": ["path"] , "srcs": ["path.test.cpp"] - , "deps": + , "private-deps": [ ["@", "catch2", "", "catch2"] , ["test", "catch-main"] , ["src/utils/cpp", "path"] |