Small code improvements based on lint warnings

- add more noexcept requirements and enforce existing
- fixing inconsistencies related to function arguments
- remove redundant static keywords
- silencing excessive lint reporting in test cases

While there, make more getters const ref.

2 files changed, 2 insertions, 2 deletions

diff --git a/test/buildtool/build_engine/target_map/target_map.test.cpp b/test/buildtool/build_engine/target_map/target_map.test.cpp
index 99fe1d4e..9f66fd92 100644
--- a/test/buildtool/build_engine/target_map/target_map.test.cpp
+++ b/test/buildtool/build_engine/target_map/target_map.test.cpp
@@ -86,7 +86,7 @@ auto SetupConfig() -> RepositoryConfig {
 
 }  // namespace
 
-TEST_CASE("simple targets", "[target_map]") {
+TEST_CASE("simple targets", "[target_map]") {  // NOLINT
     auto const storage_config = TestStorageConfig::Create();
     auto const storage = Storage::Create(&storage_config.Get());
 
diff --git a/test/buildtool/execution_api/bazel/bazel_msg_factory.test.cpp b/test/buildtool/execution_api/bazel/bazel_msg_factory.test.cpp
index 5262971c..ca9d3ca9 100644
--- a/test/buildtool/execution_api/bazel/bazel_msg_factory.test.cpp
+++ b/test/buildtool/execution_api/bazel/bazel_msg_factory.test.cpp
@@ -32,7 +32,7 @@
 namespace {
 /// \brief Create a blob from the content found in file or symlink pointed to by
 /// given path.
-[[nodiscard]] static inline auto CreateBlobFromPath(
+[[nodiscard]] inline auto CreateBlobFromPath(
     std::filesystem::path const& fpath,
     HashFunction hash_function) noexcept -> std::optional<ArtifactBlob> {
     auto const type = FileSystemManager::Type(fpath, /*allow_upwards=*/true);