| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
When user setting `remote-execution-properties` with commandline, we
assume that input value must have format with `key:val`, in that case,
if `val` includes colon(s), the real value after parsing won't be the
same as user intends to have, for example, considering commandline flag:
`--remote-execution-properties image:test.registry:8080/test`, will be
parsed into a pair `<image, test.registry>` in existing implementation.
Since it's reasonable to allow colon(s) in execution property value, we
should allow this case, and still keep the restriction on key format.
Signed-off-by: Bin Yu <yubin14@huawei.com>
|
|
protocol
|
|
Now that support for split/splice is part of the official
capabilites announcement, use those to determine if we should try
splitting/splicing. This change is actually mandatory as the new
standard mandates that clients must check before trying to use
the service.
Co-authored-by: Klaus Aehlig <klaus.aehlig@huawei.com>
|
|
... and drop the patch for adding split/splice, as this feature
is now standardized in the upstream API specification.
|
|
So far, blob split/splice was an extension of our build tool; now
it got standardized. Therefore we can, and hence should, use the
official proto file without modifications. As algorithm negociation
is not yet standardized, drop it for now; we will readd it, once
a standard is agreed upon.
|
|
... and while there, add Oxford comma to make the comment clearer.
|
|
While our presentation shows the details of only up to 30
non-cached actions, the count reported in the heading should
still be the total count of all non-cached actions. Fix this.
|
|
|
|
If calling just, the shared Git CAS lock, if taken, now lasts past
the exec call, the same way as the CAS lock does, in order to
prevent any rotation taking place in between.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
...as these features have already been implemented and
appropriately documented.
|
|
|
|
While there, combine all the scripts to a single section.
|
|
In commit da17ef5b04815ea3c6605274141a2e2b3b53b217, boringssl
was (among other dependencies) updated. Due to this updated, ["",
"crytpo-lib"] became a C++ library instead of a C one. Therefore,
the variables governing C++ compilation should be flexible as well.
|
|
... and while here, added the missing C compiler dependency.
|
|
|
|
|
|
As there is no guarantee that "out_dirs" are generated on action set
up, do so manually (being OK with the files already being present).
|
|
|
|
The google-default-arguments check normally imposes that virtual
methods have no default arguments. For our use-cases, all
implementations of such methods are expected to use the same
default arguments, and thus this check is manually disabled via
NOLINT comments. However, this is not done consistently.
This commit cleans this up and clarifies our intent by:
- removing the default values (and the NOLINT statement) for all
implementations of virtual methods with default argument values,
matching the desired intended behaviour, but
- keeping the clang-tidy check for future cases where derived
classes would want to provide each different defaults.
|
|
...for skipped individual check.
|
|
|
|
|
|
|
|
... and prepare local execution for clients
using only RBEv2.1 (setting only output_paths).
|
|
|
|
... as it is only needed for local execution, there is no
need to provide it in the common api interface.
|
|
|
|
... as Justbuild has a strict separation between output
files and output directories, but the RBE protocol does
not necessarily maintain such a separation and therefore
does not perform such a verification.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
When presenting a build, the output artifacts are hidden behind a
"details" environment to not overload the user with long list of,
e.g., test results (especially if generated by a test matrix). If,
however, only a single artifact is built, there is no reason to
hide it; so simply show it.
|
|
Given the just added json-file formatter, we can generate a diff
formatting properly all json files, i.e., all target, rules, and
expression files, by applying that formatter to every target file
and combining the patches. A target description doing precisely
this can easily be obtained as computed root. In this way, we also
make good use of caching. To avoid doing recomputing the target
description unnecessarily, we factor through the tree structure of
the repository tree; the latter, we obtain from the to-git view of
the top-level directory, whereas for computing the diff we use the
actual (not necessarily committed) files.
|
|
... that is aware of the order-independent fields in our C++ rules.
Co-authored-by: Maksim Denisov <denisov.maksim@huawei.com>
Co-authored-by: Oliver Reiche <oliver.reiche@huawei.com>
Co-authored-by: Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com>
Co-authored-by: Alberto Sartori <alberto.sartori@huawei.com>
|
|
Our lint target already provides a target for the diff obtained
from clang format. Add a convenience script computing and applying
that patch.
|
|
|
