Age | Commit message (Collapse) | Author | |
---|---|---|---|
2024-09-19 | Unify logic of adding to CAS in ByteStreamServer and CASServer | Maksim Denisov | |
...by calling the generalized CASUtils's implementation. | |||
2024-09-19 | Implement CASUtils::Add{Data, File}toCAS | Maksim Denisov | |
...that both use the same templated class CASContentValidator. | |||
2024-09-18 | Add missing #endif comments in headers | Maksim Denisov | |
2024-09-18 | Implement ByteStreamUtils::WriteRequest class | Maksim Denisov | |
...and remove split serialization/deserialization logic. | |||
2024-09-18 | Implement ByteStreamUtils::ReadRequest class | Maksim Denisov | |
...and remove split serialization/deserialization implementations. | |||
2024-09-18 | Introduce ByteStreamUtils, wrap kChunkSize | Maksim Denisov | |
...and use the qualified name ByteStreamUtils::kChunkSize | |||
2024-09-16 | remote execution: Check validity of symlinks | Paul Cristian Sarbu | |
Invalid entries, currently all upwards symlinks (pending implementation of a better way of handling them), are now identified and handled properly: in compatible mode on the client side, during handling of remote response, and in native mode on the server side during the population of the action result. | |||
2024-09-16 | execution_response: Allow failures to be reported while populating | Paul Cristian Sarbu | |
As populating the containers from remote response only takes place once, no assumptions should be made that this cannot fail (for example if wrong or invalid entries were produced). Instead, return error messages on failure to callers that can log accordingly. | |||
2024-09-13 | Remove std::move of const value and avoid non-movable intermediate variables | Klaus Aehlig | |
2024-09-13 | Check compatibility in execution services based on the hash type | Maksim Denisov | |
2024-09-13 | Pass HashFunction::Type to CapabilitiesServer | Maksim Denisov | |
...to get the protocol type. | |||
2024-09-13 | Rename Compatibility class to ProtocolTraits | Maksim Denisov | |
...and move it to the common stage. | |||
2024-09-09 | Change validation of hash in OperationsServiceImpl | Maksim Denisov | |
2024-09-09 | Fix typo in OperationsServiceImpl's name | Maksim Denisov | |
2024-09-09 | Validate hashes in ExecutionServiceImpl | Maksim Denisov | |
2024-09-09 | Introduce minor fixes to ExecutionServiceImpl | Maksim Denisov | |
1. Mark local variables const if needed; 2. Remove redundant fmt::format calls. | |||
2024-09-09 | Validate hashes in CASServiceImpl | Maksim Denisov | |
2024-09-09 | Introduce minor fixes to CASServiceImpl | Maksim Denisov | |
1. Mark local variables constant if needed; 2. Remove redundant fmt::format calls; 3. Acquire storage's lock after conversion of data. | |||
2024-09-09 | Validate hashes in BytestreamServiceImpl | Maksim Denisov | |
2024-09-09 | Introduce minor fixes to BytestreamServer | Maksim Denisov | |
1. Mark local variables constant if needed; 2. Remove redundant fmt::format calls; 3. Return bazel_re::Digest from resourse name parsing. | |||
2024-09-09 | Validate hashes in ActionCacheServiceImpl | Maksim Denisov | |
2024-08-30 | Cast ArtifactDigest to bazel_re::Digest explicitly | Maksim Denisov | |
...to simplify further refactoring. | |||
2024-08-30 | Replace bazel_re::Digest in LocalAC | Maksim Denisov | |
...with ArtifactDigest. | |||
2024-08-30 | Replace bazel_re::Digest in CASUtils | Maksim Denisov | |
...with ArtifactDigest | |||
2024-08-30 | Replace bazel_re::Digest in LocalCAS::CheckTreeInvariant | Maksim Denisov | |
...with ArtifactDigest | |||
2024-08-30 | Replace bazel_re::Digest in LocalCAS::Split/Splice | Maksim Denisov | |
...with ArtifactDigest. | |||
2024-08-30 | Replace bazel_re::Digest in LocalCAS::{...}Path | Maksim Denisov | |
...with ArtifactDigest. | |||
2024-08-30 | Return the IsTree flag from ArtifactDigest | Maksim Denisov | |
...and replace obvious redundant conversions to bazel_re::Digest, which were done to ensure that the digest represents a tree. | |||
2024-08-27 | bytestream server: also enforce the tree invariant | Klaus Aehlig | |
2024-08-27 | Bytestream server: verify hash of uploaded object | Klaus Aehlig | |
... and correctly report the error. - If we cannot store the bytes we received, this is an internal error. - If the bytes received have a different hash than announced, report this user error as INVLID_ARGUMENT. | |||
2024-08-27 | Reformat code to comply with clang-format 18 | Klaus Aehlig | |
... while keeping our .clang-format file. | |||
2024-08-07 | Remove code duplication from CasServer | Maksim Denisov | |
2024-08-07 | Pass a longrunning operation to ExecutionServer::WriteResult by rvalue | Maksim Denisov | |
2024-08-07 | ExecutionServer: use one method for conversion to IExecutionAction | Maksim Denisov | |
2024-08-07 | ExecutionServer: use one method for conversion to bazel ExecuteResponse | Maksim Denisov | |
2024-08-07 | ExecutionServer: Move creation of ActionResult to a static function | Maksim Denisov | |
2024-08-07 | ExecutionServer: move creation of bazel instances to functions | Maksim Denisov | |
2024-08-07 | Remove ExecutionServiceImpl::StoreActionResult method | Maksim Denisov | |
...and move the storing logic to Execute directly. There is no need to pass additional parameters to the method to just perform a check inside, and after this removal there is no need to preserve a one-line method. | |||
2024-08-07 | Use expected to return errors from ExecutionServiceImpl's methods | Maksim Denisov | |
2024-08-07 | ExecutionServer: remove redundant scopes | Maksim Denisov | |
2024-08-07 | Refactor read/write logic in BytestreamServer | Maksim Denisov | |
1. In reading remove additional buffer field and reuse the response's buffer; 2. In writing preserve the file descriptor alive. | |||
2024-08-07 | Generate bazel trees in LocalCasReader | Maksim Denisov | |
...and use this functionality in ExecutionServer | |||
2024-08-07 | Avoid deep copies of containers in responses. | Maksim Denisov | |
2024-08-07 | Replace classic C boolean operators with keywords | Maksim Denisov | |
! => not; && => and, || => or | |||
2024-08-01 | Execution API: support cwd | Klaus Aehlig | |
... following the remote-execution standard that all output paths (but none of the input paths) are relative to the working directory. Therefore, the executor has to do the path translation. For our implementation of the API interface - the local API now handles cwd correctly, - the remote API forwards cwd correctly, and - the git API continues to report actions as not implemented. | |||
2024-07-30 | Pass RemoteContext to execution server | Paul Cristian Sarbu | |
2024-07-30 | Use LocalContext in execution and serve services | Paul Cristian Sarbu | |
The context is passed by not_null const pointer in order to avoid binding to temporaries, and it or parts of it get stored by const ref where needed. | |||
2024-07-22 | Make ServerImpl a general class, not singleton | Paul Cristian Sarbu | |
2024-07-19 | Make OperationCache a general class, not singleton | Paul Cristian Sarbu | |
As it is used by just execute only, instantiate it inside the ExecutionServer, which reads and writes to the cache map, and pass a const ref to OperationsServer, which only queries. | |||
2024-07-05 | Pass StorageConfig and Storage to ServerImpl | Maksim Denisov | |