Age | Commit message (Collapse) | Author | |
---|---|---|---|
2024-10-25 | Add new Git execution api that can interact with any remote | Paul Cristian Sarbu | |
...irrespective of the used protocol. This api is useful in enabling just-mr and the SourceTree service of just serve to interact seamlessly with any remote-execution endpoint. | |||
2024-10-25 | Add utility methods for digest mappings | Paul Cristian Sarbu | |
These allow to read and write file associations between known digests in different CAS instances. | |||
2024-10-25 | BazelMsgFactory: Add method to create bazel Directory from Git tree | Paul Cristian Sarbu | |
2024-10-25 | bugfix: bazel_network.cpp: fix handling of ongoing actions | Alberto Sartori | |
The rpc Execution::Execute returns stream google.longrunning.Operation. When the client reads the stream, the server can report that the operation is still in progress and the client has to wait. Before this patch, we were not checking for this particular condition. As a result, an ongoing action was interpreted as an execution failure. | |||
2024-10-10 | Remove from OSS intersecting public-private dependencies | Maksim Denisov | |
2024-10-08 | Name local variables using lower_case | Maksim Denisov | |
...and private members using lower_case_ | |||
2024-10-08 | Name static constants using kCamelCase. | Maksim Denisov | |
2024-10-08 | Name type template parameters using CamelCase. | Maksim Denisov | |
2024-10-08 | Name classes, structs and enums using CamelCase. | Maksim Denisov | |
2024-10-07 | Enable cppcoreguidelines-* checks. | Maksim Denisov | |
2024-10-07 | Disable misc-no-recursion check | Maksim Denisov | |
...since we use recursion for trees a lot, but skip this check manually. | |||
2024-10-07 | Enable readability-* checks. | Maksim Denisov | |
2024-10-07 | Enable readability-redundant-member-init check. | Maksim Denisov | |
2024-10-07 | Enable bugprone-empty-catch check. | Maksim Denisov | |
2024-10-07 | Enable bugprone-exception-escape check | Maksim Denisov | |
2024-10-07 | Enable bugprone-unhandled-exception-at-new check. | Maksim Denisov | |
2024-10-07 | Enable bugprone-implicit-widening-of-multiplication-result check. | Maksim Denisov | |
2024-10-07 | Enable bugprone-narrowing-conversions check | Maksim Denisov | |
2024-09-26 | Fix enum sizes proposed by clang-tidy. | Maksim Denisov | |
Enable performance-enum-size check. | |||
2024-09-26 | Fix redundant std::optional conversions | Maksim Denisov | |
...proposed by clang-tidy. Enable bugprone-optional-value-conversion check. | |||
2024-09-26 | Fix automatic moves proposed by clang-tidy. | Maksim Denisov | |
Enable performance-no-automatic-move check. | |||
2024-09-26 | Fix assignments in conditions | Maksim Denisov | |
...proposed by clang-tidy. Enable bugprone-assignment-in-if-condition check. | |||
2024-09-23 | Reorder dependencies and remove duplicates in OSS | Maksim Denisov | |
2024-09-23 | Store HashFunction by const reference. | Maksim Denisov | |
Despite the fact that HashFunction is a small type, it still makes sense to store it by reference to reflect the ownership. StorageConfig becomes the main holder. Reference holders store HashFunction by const ref and aren't allowed to change it. However, they are free to return HashFunction by value since this doesn't benefit readability anyhow. | |||
2024-09-19 | Unify logic of adding to CAS in ByteStreamServer and CASServer | Maksim Denisov | |
...by calling the generalized CASUtils's implementation. | |||
2024-09-19 | Implement CASUtils::Add{Data, File}toCAS | Maksim Denisov | |
...that both use the same templated class CASContentValidator. | |||
2024-09-18 | Add missing #endif comments in headers | Maksim Denisov | |
2024-09-18 | Avoid additional memory allocations when working with protobuf's types. | Maksim Denisov | |
Although this change doesn't benefit performance anyhow (protobuf's mutable_*() methods allocate memory lazily), it is better to let protobuf do this on its own. | |||
2024-09-18 | Remove a redundant variable | Maksim Denisov | |
2024-09-18 | TreeReaderUtils: change InfoStoreFunc interface | Maksim Denisov | |
...passing constructed Artifact::ObjectInfo by rvalue, to avoid additional copies. | |||
2024-09-18 | Implement ByteStreamUtils::WriteRequest class | Maksim Denisov | |
...and remove split serialization/deserialization logic. | |||
2024-09-18 | Implement ByteStreamUtils::ReadRequest class | Maksim Denisov | |
...and remove split serialization/deserialization implementations. | |||
2024-09-18 | Introduce ByteStreamUtils, wrap kChunkSize | Maksim Denisov | |
...and use the qualified name ByteStreamUtils::kChunkSize | |||
2024-09-18 | Remove ByteStreamClient::{Read, Write}Many | Maksim Denisov | |
...since they were used only in tests. | |||
2024-09-18 | Remove a redundant string allocation. | Maksim Denisov | |
2024-09-17 | Small code improvements based on lint warnings | Paul Cristian Sarbu | |
- add more noexcept requirements and enforce existing - fixing inconsistencies related to function arguments - remove redundant static keywords - silencing excessive lint reporting in test cases While there, make more getters const ref. | |||
2024-09-16 | local execution: Check validity of symlinks | Paul Cristian Sarbu | |
Invalid entries, currently all upwards symlinks (pending implementation of a better way of handling them), are now identified and handled similarly to remote execution: in compatible mode on the client side, during handling of local response, and in native mode during the population of the local action result. | |||
2024-09-16 | remote execution: Check validity of symlinks | Paul Cristian Sarbu | |
Invalid entries, currently all upwards symlinks (pending implementation of a better way of handling them), are now identified and handled properly: in compatible mode on the client side, during handling of remote response, and in native mode on the server side during the population of the action result. | |||
2024-09-16 | bazel_execution_client: Remove duplication of error messages | Paul Cristian Sarbu | |
...during WithRetry, as we know that the error message of the callable has already been appropriately logged. | |||
2024-09-16 | bazel_response: Improve error reporting for uploading trees | Paul Cristian Sarbu | |
2024-09-16 | execution_response: Allow failures to be reported while populating | Paul Cristian Sarbu | |
As populating the containers from remote response only takes place once, no assumptions should be made that this cannot fail (for example if wrong or invalid entries were produced). Instead, return error messages on failure to callers that can log accordingly. | |||
2024-09-13 | Remove std::move of const value and avoid non-movable intermediate variables | Klaus Aehlig | |
2024-09-13 | Pass ApiBundle to RetrieveSubPathId | Maksim Denisov | |
...to get access to the protocol type. | |||
2024-09-13 | Check compatibility in execution services based on the hash type | Maksim Denisov | |
2024-09-13 | Pass HashFunction::Type to CapabilitiesServer | Maksim Denisov | |
...to get the protocol type. | |||
2024-09-13 | Pass HashFunction to BazelCasClient | Maksim Denisov | |
...to determine whether splitting-splicing functionality is supported. | |||
2024-09-13 | Check compatibility in BazelAPI based on the hash type | Maksim Denisov | |
2024-09-13 | Check compatibility in LocalAPI based on the hash type | Maksim Denisov | |
2024-09-13 | Check compatibility in readers based on the hash type | Maksim Denisov | |
2024-09-13 | Add to ProtocolTraits static functions that provide protocol-specific behaviour | Maksim Denisov | |