From 02a05d4f759dd72e8b20178b0ac048ccb0a2755e Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Fri, 13 Sep 2024 11:23:09 +0200 Subject: Fix increments in conditions ...proposed by clang-tidy. Enable bugprone-inc-dec-in-conditions check. --- .clang-tidy | 2 +- test/buildtool/build_engine/base_maps/json_file_map.test.cpp | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 03134235..282df112 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,6 +1,6 @@ FormatStyle: Google Checks: '*,-abseil-*,-altera-*,-android-*,-boost-*,-cert-*,-darwin-*,-fuchsia-*,-linuxkernel-*,-llvm-*,-llvmlibc-*,-mpi-*,-objc-*,-zircon-*' -WarningsAsErrors: 'clang-diagnostic-*,-clang-diagnostic-unused-command-line-argument,clang-analyzer-*,-clang-analyzer-cplusplus.NewDeleteLeaks,-clang-analyzer-cplusplus.StringChecker,bugprone-*,-bugprone-easily-swappable-parameters,-bugprone-unchecked-optional-access,-bugprone-narrowing-conversions,-bugprone-unhandled-exception-at-new,-bugprone-empty-catch,-bugprone-optional-value-conversion,-bugprone-implicit-widening-of-multiplication-result,-bugprone-inc-dec-in-conditions,-bugprone-exception-escape,portability-*,hicpp-*,performance-*,-performance-avoid-endl,-performance-enum-size,-performance-no-automatic-move' +WarningsAsErrors: 'clang-diagnostic-*,-clang-diagnostic-unused-command-line-argument,clang-analyzer-*,-clang-analyzer-cplusplus.NewDeleteLeaks,-clang-analyzer-cplusplus.StringChecker,bugprone-*,-bugprone-easily-swappable-parameters,-bugprone-unchecked-optional-access,-bugprone-narrowing-conversions,-bugprone-unhandled-exception-at-new,-bugprone-empty-catch,-bugprone-optional-value-conversion,-bugprone-implicit-widening-of-multiplication-result,-bugprone-exception-escape,portability-*,hicpp-*,performance-*,-performance-avoid-endl,-performance-enum-size,-performance-no-automatic-move' CheckOptions: [ { key: misc-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic, diff --git a/test/buildtool/build_engine/base_maps/json_file_map.test.cpp b/test/buildtool/build_engine/base_maps/json_file_map.test.cpp index be657cff..4a951012 100644 --- a/test/buildtool/build_engine/base_maps/json_file_map.test.cpp +++ b/test/buildtool/build_engine/base_maps/json_file_map.test.cpp @@ -146,11 +146,12 @@ TEST_CASE("non existent") { TEST_CASE("Bad syntax") { std::atomic failcont_counter{0}; + auto fail_func = [&failcont_counter]() { ++failcont_counter; }; CHECK_FALSE(ReadJsonFile( "bad.json", {"", "data_json"}, [](auto const& /* unused */) {}, /*use_git=*/false, - [&failcont_counter]() { failcont_counter++; })); + fail_func)); CHECK(failcont_counter == 1); } -- cgit v1.2.3