From 6f66c551164e860130ed60524e3456ed44b55f3e Mon Sep 17 00:00:00 2001
From: Oliver Reiche <oliver.reiche@huawei.com>
Date: Tue, 14 Jun 2022 09:57:50 +0200
Subject: Drop copy constructor for expressions

---
 src/buildtool/build_engine/expression/expression.hpp       | 2 +-
 test/buildtool/build_engine/expression/expression.test.cpp | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/buildtool/build_engine/expression/expression.hpp b/src/buildtool/build_engine/expression/expression.hpp
index 334dfb0d..8350db68 100644
--- a/src/buildtool/build_engine/expression/expression.hpp
+++ b/src/buildtool/build_engine/expression/expression.hpp
@@ -63,7 +63,7 @@ class Expression {
 
     Expression() noexcept = default;
     ~Expression() noexcept = default;
-    Expression(Expression const& other) noexcept = default;
+    Expression(Expression const& other) noexcept = delete;
     Expression(Expression&& other) noexcept = default;
     auto operator=(Expression const& other) noexcept = delete;
     auto operator=(Expression&& other) noexcept = delete;
diff --git a/test/buildtool/build_engine/expression/expression.test.cpp b/test/buildtool/build_engine/expression/expression.test.cpp
index 6929fa33..a1c434e9 100644
--- a/test/buildtool/build_engine/expression/expression.test.cpp
+++ b/test/buildtool/build_engine/expression/expression.test.cpp
@@ -156,7 +156,7 @@ TEST_CASE("Expression access", "[expression]") {  // NOLINT
         CHECK(list != list_t{});
         CHECK(list != Expression{list_t{}});
         CHECK(list != map);
-        CHECK(list != Expression{*map});
+        CHECK(list != *map);
         CHECK(list != Expression::FromJson(R"({"1":1})"_json));
 
         CHECK(map == map);
@@ -166,7 +166,7 @@ TEST_CASE("Expression access", "[expression]") {  // NOLINT
         CHECK(map != map_t{});
         CHECK(map != Expression{map_t{}});
         CHECK(map != list);
-        CHECK(map != Expression{*list});
+        CHECK(map != *list);
         CHECK(map != Expression::FromJson(R"(["3",1])"_json));
 
         // compare nullptr != null != false != 0 != "" != [] != {}
-- 
cgit v1.2.3