From 70893762d10b25cdba70d72b78a640bdb29c0dcd Mon Sep 17 00:00:00 2001 From: Klaus Aehlig Date: Mon, 28 Oct 2024 12:18:44 +0100 Subject: BatchUploadBlobs: decrease log level for retried tasks In BatchUploadBlobs we accept short writes and, in case of no progress, fall back to single blob upload. Therefore, failure to upload blobs is not fatal and therefore should not be reported at error level. Decrease the log level accordingly: a protocol failure to upload is a performance-related event (as the retry needs additional time), catching an internal exception is something that shouldn't really happen, so we warn the user. --- src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp index 54654233..fa299187 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp @@ -542,12 +542,14 @@ auto BazelCasClient::BatchUpdateBlobs( return batch_update_blobs(request); }, retry_config_, - logger_); + logger_, + LogLevel::Performance); })) { - logger_.Emit(LogLevel::Error, "Failed to BatchUpdateBlobs."); + logger_.Emit(LogLevel::Performance, "Failed to BatchUpdateBlobs."); } } catch (...) { - logger_.Emit(LogLevel::Error, "Caught exception in DoBatchUpdateBlobs"); + logger_.Emit(LogLevel::Warning, + "Caught exception in DoBatchUpdateBlobs"); } logger_.Emit(LogLevel::Trace, [begin, end, &result]() { std::ostringstream oss{}; -- cgit v1.2.3