From 030af3e7af210617df00bf850476df6b46fb004d Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Mon, 30 Sep 2024 16:16:20 +0200 Subject: Enable readability-* checks. --- .../build_engine/base_maps/entity_name.hpp | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) (limited to 'src/buildtool/build_engine/base_maps/entity_name.hpp') diff --git a/src/buildtool/build_engine/base_maps/entity_name.hpp b/src/buildtool/build_engine/base_maps/entity_name.hpp index def2cbe6..ad2b368d 100644 --- a/src/buildtool/build_engine/base_maps/entity_name.hpp +++ b/src/buildtool/build_engine/base_maps/entity_name.hpp @@ -112,14 +112,19 @@ template std::optional> logger = std::nullopt) noexcept -> std::optional { try { - bool const is_file = s0 == EntityName::kFileLocationMarker; - bool const is_glob = s0 == EntityName::kGlobMarker; - bool const is_symlink = s0 == EntityName::kSymlinkLocationMarker; - auto const ref_type = - is_file ? ReferenceType::kFile - : (is_glob ? ReferenceType::kGlob - : (is_symlink ? ReferenceType::kSymlink - : ReferenceType::kTree)); + auto get_ref_type = [](std::string const& s) -> ReferenceType { + if (s == EntityName::kFileLocationMarker) { + return ReferenceType::kFile; + } + if (s == EntityName::kGlobMarker) { + return ReferenceType::kGlob; + } + if (s == EntityName::kSymlinkLocationMarker) { + return ReferenceType::kSymlink; + } + return ReferenceType::kTree; + }; + auto const ref_type = get_ref_type(s0); if (list_size == 3) { if (IsString(list[2])) { auto const& name = GetString(list[2]); -- cgit v1.2.3