From 3b7b4d7b64aebc4484f4d51d887af1fcbda763ec Mon Sep 17 00:00:00 2001 From: Klaus Aehlig Date: Thu, 3 Mar 2022 17:38:28 +0100 Subject: rule_map: improve error message by proper quoting Our rule names can be arbitrary strings, so improve readability of error message by properly quoting the rule name; while there, also properly quote the module name, resulting in better readability if the module is "". --- src/buildtool/build_engine/base_maps/rule_map.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/buildtool/build_engine/base_maps/rule_map.cpp') diff --git a/src/buildtool/build_engine/base_maps/rule_map.cpp b/src/buildtool/build_engine/base_maps/rule_map.cpp index 7bdc14e4..b6f56b2b 100644 --- a/src/buildtool/build_engine/base_maps/rule_map.cpp +++ b/src/buildtool/build_engine/base_maps/rule_map.cpp @@ -237,10 +237,10 @@ auto CreateRuleMap(gsl::not_null const& rule_file_map, auto json_values) { auto rule_it = json_values[0]->find(id.name); if (rule_it == json_values[0]->end()) { - (*logger)( - fmt::format( - "Cannot find rule {} in {}", id.name, id.module), - true); + (*logger)(fmt::format("Cannot find rule {} in {}", + nlohmann::json(id.name).dump(), + nlohmann::json(id.module).dump()), + true); return; } -- cgit v1.2.3