From 580539ab08a098e7f348fee3c46fbf5d44cd4d54 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Thu, 16 May 2024 11:24:14 +0200 Subject: RepositoryConfig: Instance should not be changed once populated Once a RepositoryConfig instance gets populated, it must never be changed again. Therefore, all functions accepting these instances should only take them as pointers to const. --- src/buildtool/build_engine/base_maps/rule_map.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/buildtool/build_engine/base_maps/rule_map.cpp') diff --git a/src/buildtool/build_engine/base_maps/rule_map.cpp b/src/buildtool/build_engine/base_maps/rule_map.cpp index 19b1ed80..15999d01 100644 --- a/src/buildtool/build_engine/base_maps/rule_map.cpp +++ b/src/buildtool/build_engine/base_maps/rule_map.cpp @@ -46,7 +46,7 @@ auto const kRuleFields = std::unordered_set{"anonymous", [[nodiscard]] auto ReadAnonymousObject( EntityName const& id, nlohmann::json const& json, - gsl::not_null const& repo_config, + gsl::not_null const& repo_config, AsyncMapConsumerLoggerPtr const& logger) -> std::optional { auto obj = GetOrDefault(json, "anonymous", nlohmann::json::object()); @@ -154,7 +154,7 @@ auto const kRuleFields = std::unordered_set{"anonymous", [[nodiscard]] auto ReadImplicitObject( EntityName const& id, nlohmann::json const& json, - gsl::not_null const& repo_config, + gsl::not_null const& repo_config, AsyncMapConsumerLoggerPtr const& logger) -> std::optional { auto map = GetOrDefault(json, "implicit", nlohmann::json::object()); @@ -242,7 +242,7 @@ auto const kRuleFields = std::unordered_set{"anonymous", auto CreateRuleMap(gsl::not_null const& rule_file_map, gsl::not_null const& expr_map, - gsl::not_null const& repo_config, + gsl::not_null const& repo_config, std::size_t jobs) -> UserRuleMap { auto user_rule_creator = [rule_file_map, expr_map, repo_config]( auto ts, -- cgit v1.2.3