From 5baab75fd2ae62b6f6407991922fe234f9e73c88 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Thu, 26 Sep 2024 14:20:16 +0200 Subject: Fix redundant std::optional conversions ...proposed by clang-tidy. Enable bugprone-optional-value-conversion check. --- src/buildtool/build_engine/expression/expression.hpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'src/buildtool/build_engine/expression/expression.hpp') diff --git a/src/buildtool/build_engine/expression/expression.hpp b/src/buildtool/build_engine/expression/expression.hpp index cbfb2f24..e5788e38 100644 --- a/src/buildtool/build_engine/expression/expression.hpp +++ b/src/buildtool/build_engine/expression/expression.hpp @@ -152,11 +152,7 @@ class Expression { [[nodiscard]] auto At( std::string const& key) && -> std::optional { - auto value = std::move(*this).Map().Find(key); - if (value) { - return std::move(*value); - } - return std::nullopt; + return std::move(*this).Map().Find(key); } template -- cgit v1.2.3