From 80caf4d4566371cf02923abdc26ae2e8258ed376 Mon Sep 17 00:00:00 2001 From: Klaus Aehlig Date: Tue, 19 Apr 2022 18:06:21 +0200 Subject: Remove unused "+" on expressions To concatenate lists (the only ability the "+" operator had), use "++". --- .../build_engine/expression/expression.hpp | 21 --------------------- 1 file changed, 21 deletions(-) (limited to 'src/buildtool/build_engine/expression/expression.hpp') diff --git a/src/buildtool/build_engine/expression/expression.hpp b/src/buildtool/build_engine/expression/expression.hpp index 52e67282..412de057 100644 --- a/src/buildtool/build_engine/expression/expression.hpp +++ b/src/buildtool/build_engine/expression/expression.hpp @@ -343,27 +343,6 @@ class Expression { [[nodiscard]] auto ComputeHash() const noexcept -> std::string; }; -[[nodiscard]] inline auto operator+(Expression const& lhs, - Expression const& rhs) -> Expression { - if (lhs.data_.index() != rhs.data_.index()) { - throw Expression::ExpressionTypeError{ - fmt::format("Cannot add expressions of different type: {} != {}", - lhs.TypeString(), - rhs.TypeString())}; - } - if (not lhs.IsList()) { - throw Expression::ExpressionTypeError{fmt::format( - "Cannot add expressions of type '{}'.", lhs.TypeString())}; - } - auto list = Expression::list_t{}; - auto const& llist = lhs.List(); - auto const& rlist = rhs.List(); - list.reserve(llist.size() + rlist.size()); - list.insert(list.begin(), llist.begin(), llist.end()); - list.insert(list.end(), rlist.begin(), rlist.end()); - return Expression{list}; -} - namespace std { template <> struct hash { -- cgit v1.2.3