From 0fc0d9118b5e525fa582de0286c8e83bb0da4e16 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Fri, 4 Oct 2024 14:42:28 +0200 Subject: Disable misc-no-recursion check ...since we use recursion for trees a lot, but skip this check manually. --- src/buildtool/build_engine/expression/target_result.cpp | 7 ------- 1 file changed, 7 deletions(-) (limited to 'src/buildtool/build_engine/expression/target_result.cpp') diff --git a/src/buildtool/build_engine/expression/target_result.cpp b/src/buildtool/build_engine/expression/target_result.cpp index 61f5a17f..c95a803f 100644 --- a/src/buildtool/build_engine/expression/target_result.cpp +++ b/src/buildtool/build_engine/expression/target_result.cpp @@ -65,7 +65,6 @@ auto SerializeTargetResultWithReplacement( // If replacements is set, replace any contained // non-known artifact by known artifact from replacement. Throws runtime_error // if no replacement is found. -// NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto SerializeExpression( gsl::not_null*> const& nodes, @@ -178,7 +177,6 @@ auto SerializeTargetResultWithReplacement( return id; } -// NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto DeserializeExpression( HashFunction::Type hash_type, nlohmann::json const& entry, @@ -327,7 +325,6 @@ auto SerializeTargetResultWithReplacement( // Serialize artifact map to JSON. If replacements is set, replace // non-known artifacts by known artifacts from replacement. Throws runtime_error // if no replacement is found. -// NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto SerializeArtifactMap( ExpressionPtr const& expr, std::unordered_map const& @@ -365,7 +362,6 @@ auto SerializeTargetResultWithReplacement( // Serialize provides map to JSON. If replacements is set, replace // non-known artifacts by known artifacts from replacement. Throws runtime_error // if no replacement is found. -// NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto SerializeProvidesMap( ExpressionPtr const& expr, std::unordered_map const& @@ -398,7 +394,6 @@ auto JsonSet(nlohmann::json const& j) -> std::unordered_set { return result; } -// NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto DeserializeProvidesMap(HashFunction::Type hash_type, nlohmann::json const& json) -> ExpressionPtr { @@ -415,7 +410,6 @@ auto JsonSet(nlohmann::json const& j) -> std::unordered_set { // Serialize TargetResult to JSON. If replacements is set, replace non-known // artifacts by known artifacts from replacement. Throws runtime_error if no // replacement is found. -// NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto SerializeTargetResultWithReplacement( TargetResult const& result, std::unordered_map const& @@ -446,7 +440,6 @@ auto TargetResult::ReplaceNonKnownAndToJson( return std::nullopt; } -// NOLINTNEXTLINE(misc-no-recursion) auto TargetResult::FromJson(HashFunction::Type hash_type, nlohmann::json const& json) noexcept -> std::optional { -- cgit v1.2.3