From 580539ab08a098e7f348fee3c46fbf5d44cd4d54 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Thu, 16 May 2024 11:24:14 +0200 Subject: RepositoryConfig: Instance should not be changed once populated Once a RepositoryConfig instance gets populated, it must never be changed again. Therefore, all functions accepting these instances should only take them as pointers to const. --- src/buildtool/build_engine/target_map/target_map.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/buildtool/build_engine/target_map/target_map.cpp') diff --git a/src/buildtool/build_engine/target_map/target_map.cpp b/src/buildtool/build_engine/target_map/target_map.cpp index db0d5512..0c713cd7 100644 --- a/src/buildtool/build_engine/target_map/target_map.cpp +++ b/src/buildtool/build_engine/target_map/target_map.cpp @@ -309,7 +309,7 @@ void withDependencies( const BuildMaps::Base::UserRulePtr& rule, const TargetData::Ptr& data, const BuildMaps::Target::ConfiguredTarget& key, - const gsl::not_null& repo_config, + const gsl::not_null& repo_config, std::unordered_map params, const BuildMaps::Target::TargetMap::SetterPtr& setter, const BuildMaps::Target::TargetMap::LoggerPtr& logger, @@ -994,7 +994,7 @@ void withRuleDefinition( const BuildMaps::Base::UserRulePtr& rule, const TargetData::Ptr& data, const BuildMaps::Target::ConfiguredTarget& key, - const gsl::not_null& repo_config, + const gsl::not_null& repo_config, const BuildMaps::Target::TargetMap::SubCallerPtr& subcaller, const BuildMaps::Target::TargetMap::SetterPtr& setter, const BuildMaps::Target::TargetMap::LoggerPtr& logger, @@ -1350,7 +1350,7 @@ void withRuleDefinition( void withTargetsFile( const BuildMaps::Target::ConfiguredTarget& key, - const gsl::not_null& repo_config, + const gsl::not_null& repo_config, const ActiveTargetCache& target_cache, const gsl::not_null& stats, const gsl::not_null& exports_progress, @@ -1479,7 +1479,7 @@ void withTargetsFile( void withTargetNode( const BuildMaps::Target::ConfiguredTarget& key, - const gsl::not_null& repo_config, + const gsl::not_null& repo_config, const gsl::not_null& rule_map, const gsl::not_null& ts, const BuildMaps::Target::TargetMap::SubCallerPtr& subcaller, @@ -1777,7 +1777,7 @@ auto CreateTargetMap( directory_entries_map, const gsl::not_null& absent_target_map, const gsl::not_null& result_map, - const gsl::not_null& repo_config, + const gsl::not_null& repo_config, const ActiveTargetCache& target_cache, const gsl::not_null& stats, const gsl::not_null& exports_progress, -- cgit v1.2.3