From 5f6ff55e97104e46c1b5c2c94b39ea0fca35ca7c Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Thu, 7 Mar 2024 15:44:28 +0100 Subject: just: Replace singletons for progress tracking and statistics... ...with regular instances that have controlled life-times. This avoids race conditions in tracking and reporting the results of analysis and build, as the serve endpoint can orchestrate multiple builds at the same time asynchronously. As a bonus side-effect this also ensures the correctness of the progress reporting per orchestrated build. --- src/buildtool/build_engine/target_map/target_map.hpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/buildtool/build_engine/target_map/target_map.hpp') diff --git a/src/buildtool/build_engine/target_map/target_map.hpp b/src/buildtool/build_engine/target_map/target_map.hpp index 2832eb35..eda27b77 100644 --- a/src/buildtool/build_engine/target_map/target_map.hpp +++ b/src/buildtool/build_engine/target_map/target_map.hpp @@ -28,6 +28,7 @@ #include "src/buildtool/build_engine/target_map/configured_target.hpp" #include "src/buildtool/build_engine/target_map/result_map.hpp" #include "src/buildtool/common/repository_config.hpp" +#include "src/buildtool/common/statistics.hpp" #include "src/buildtool/multithreading/async_map_consumer.hpp" #include "src/buildtool/storage/target_cache.hpp" @@ -44,6 +45,7 @@ auto CreateTargetMap( const gsl::not_null&, const gsl::not_null&, const ActiveTargetCache&, + const gsl::not_null& stats, std::size_t jobs = 0) -> TargetMap; // use explicit cast to std::function to allow template deduction when used -- cgit v1.2.3