From 0fd32f8b9d707d807c236156de12118b0a695d69 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Tue, 14 May 2024 16:48:20 +0200 Subject: logging: Do not make assumptions in emit calls The Emit method of the Logger class, when called with a string as second argument, expects it to be a format string. It should be considered a programming error to pass a string variable as that argument without knowing for certain that it does not contain any format escape character ('{', '}'); instead, one should be conservative and use the blind format string "{}" as second argument and pass the unknown string variable as third argument. --- src/buildtool/common/remote/retry.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/buildtool/common/remote/retry.hpp') diff --git a/src/buildtool/common/remote/retry.hpp b/src/buildtool/common/remote/retry.hpp index 4e1e3492..0f82a48f 100644 --- a/src/buildtool/common/remote/retry.hpp +++ b/src/buildtool/common/remote/retry.hpp @@ -61,7 +61,7 @@ template } if (fatal) { if (error_msg) { - logger.Emit(LogLevel::Error, *error_msg); + logger.Emit(LogLevel::Error, "{}", *error_msg); } return false; } -- cgit v1.2.3