From b716a901802314ad57588b4b75f9ea785219827a Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Tue, 10 Sep 2024 12:16:35 +0200 Subject: Return ArtifactDigest from RepositoryConfig::RepositoryKey ...to prevent additional conversions to ArtifactDigest from plain strings. --- src/buildtool/common/repository_config.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'src/buildtool/common/repository_config.cpp') diff --git a/src/buildtool/common/repository_config.cpp b/src/buildtool/common/repository_config.cpp index 52694d0b..804bec2e 100644 --- a/src/buildtool/common/repository_config.cpp +++ b/src/buildtool/common/repository_config.cpp @@ -36,18 +36,16 @@ auto RepositoryConfig::RepositoryInfo::BaseContentDescription() const auto RepositoryConfig::RepositoryKey(Storage const& storage, std::string const& repo) const noexcept - -> std::optional { + -> std::optional { auto const unique = DeduplicateRepo(repo, storage.GetHashFunction()); if (auto const* data = Data(unique)) { // compute key only once (thread-safe) return data->key.SetOnceAndGet( - [this, &storage, &unique]() -> std::optional { + [this, &storage, &unique]() -> std::optional { if (auto graph = BuildGraphForRepository( unique, storage.GetHashFunction())) { auto const& cas = storage.CAS(); - if (auto digest = cas.StoreBlob(graph->dump(2))) { - return digest->hash(); - } + return cas.StoreBlob(graph->dump(2)); } return std::nullopt; }); -- cgit v1.2.3