From c1edc2e21ecf381470d71767dc38a83c85f57d23 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Mon, 5 Aug 2024 09:33:44 +0200 Subject: Avoid deep copies of containers in responses. --- src/buildtool/execution_api/common/execution_response.hpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'src/buildtool/execution_api/common/execution_response.hpp') diff --git a/src/buildtool/execution_api/common/execution_response.hpp b/src/buildtool/execution_api/common/execution_response.hpp index 3ad4e2ba..57e1f087 100644 --- a/src/buildtool/execution_api/common/execution_response.hpp +++ b/src/buildtool/execution_api/common/execution_response.hpp @@ -56,13 +56,12 @@ class IExecutionResponse { [[nodiscard]] virtual auto StdOut() noexcept -> std::string = 0; - [[nodiscard]] virtual auto ActionDigest() const noexcept -> std::string = 0; + [[nodiscard]] virtual auto ActionDigest() const noexcept + -> std::string const& = 0; - [[nodiscard]] virtual auto Artifacts() noexcept -> ArtifactInfos = 0; - - // Artifacts plus extra useful info - [[nodiscard]] virtual auto ArtifactsWithDirSymlinks() noexcept - -> std::pair = 0; + [[nodiscard]] virtual auto Artifacts() noexcept -> ArtifactInfos const& = 0; + [[nodiscard]] virtual auto DirectorySymlinks() noexcept + -> DirSymlinks const& = 0; }; #endif // INCLUDED_SRC_BUILDTOOL_EXECUTION_API_COMMON_REMOTE_EXECUTION_RESPONSE_HPP -- cgit v1.2.3