From dd9fa2841fcb5983b4ea845d5f9dc1b635d8dd18 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Fri, 16 May 2025 17:35:41 +0200 Subject: Executor: Check validity of action outputs in compatible mode This ensures that any entries that the standard remote execution protocol accepts but are invalid in justbuild, i.e., upwards symlinks, are rejected. For this purpose, do not fail in the action response instances, just perform the check there, as all required information is available, and set a flag that the executor can check as needed. --- src/buildtool/execution_api/common/execution_response.hpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/buildtool/execution_api/common/execution_response.hpp') diff --git a/src/buildtool/execution_api/common/execution_response.hpp b/src/buildtool/execution_api/common/execution_response.hpp index 882750fe..65fd0ba9 100644 --- a/src/buildtool/execution_api/common/execution_response.hpp +++ b/src/buildtool/execution_api/common/execution_response.hpp @@ -77,6 +77,8 @@ class IExecutionResponse { -> expected, std::string> = 0; [[nodiscard]] virtual auto DirectorySymlinks() noexcept -> expected, std::string> = 0; + [[nodiscard]] virtual auto HasUpwardsSymlinks() noexcept + -> expected = 0; }; #endif // INCLUDED_SRC_BUILDTOOL_EXECUTION_API_COMMON_REMOTE_EXECUTION_RESPONSE_HPP -- cgit v1.2.3