From d83c997ad5a866f4fbb38d4a81e7edf70a491db2 Mon Sep 17 00:00:00 2001 From: Sascha Roloff Date: Fri, 23 Feb 2024 09:32:54 +0100 Subject: Refactor split and splice implementations. Currently, the implementations of the split and splice operation are both hidden behind the Bazel API implementation. This was sufficient to implement splitting at the server and splicing at the client. In order to support the other direction of splitting at the client and splicing at the server while reusing their implementations, the code needs to be refactored. First, the functionality of split and splice are explicitly exposed at the general execution API interface and implemented in the sub APIs. Second, the implementations of split and splice are factored into a separate utils class. --- src/buildtool/execution_api/common/execution_api.hpp | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) (limited to 'src/buildtool/execution_api/common') diff --git a/src/buildtool/execution_api/common/execution_api.hpp b/src/buildtool/execution_api/common/execution_api.hpp index 43e16783..993f6d17 100644 --- a/src/buildtool/execution_api/common/execution_api.hpp +++ b/src/buildtool/execution_api/common/execution_api.hpp @@ -135,6 +135,26 @@ class IExecutionApi { [[nodiscard]] virtual auto IsAvailable( std::vector const& digests) const noexcept -> std::vector = 0; + + [[nodiscard]] virtual auto SplitBlob(ArtifactDigest const& /*blob_digest*/) + const noexcept -> std::optional> { + return std::nullopt; + } + + [[nodiscard]] virtual auto BlobSplitSupport() const noexcept -> bool { + return false; + } + + [[nodiscard]] virtual auto SpliceBlob( + ArtifactDigest const& /*blob_digest*/, + std::vector const& /*chunk_digests*/) const noexcept + -> std::optional { + return std::nullopt; + } + + [[nodiscard]] virtual auto BlobSpliceSupport() const noexcept -> bool { + return false; + } }; #endif // INCLUDED_SRC_BUILDTOOL_EXECUTION_API_COMMON_EXECUTION_APIHPP -- cgit v1.2.3