From 808352e5473f90b4042370e037788d3793f4b8c3 Mon Sep 17 00:00:00 2001 From: Alberto Sartori Date: Wed, 15 Nov 2023 16:08:18 +0100 Subject: just-execute: verify the validity of all the hashes received over the wire --- src/buildtool/execution_api/execution_service/ac_server.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'src/buildtool/execution_api/execution_service/ac_server.cpp') diff --git a/src/buildtool/execution_api/execution_service/ac_server.cpp b/src/buildtool/execution_api/execution_service/ac_server.cpp index 304d70dd..a83ba8a9 100644 --- a/src/buildtool/execution_api/execution_service/ac_server.cpp +++ b/src/buildtool/execution_api/execution_service/ac_server.cpp @@ -14,13 +14,19 @@ #include "src/buildtool/execution_api/execution_service/ac_server.hpp" -#include "fmt/core.h" +#include + #include "src/buildtool/storage/garbage_collector.hpp" +#include "src/utils/cpp/verify_hash.hpp" auto ActionCacheServiceImpl::GetActionResult( ::grpc::ServerContext* /*context*/, const ::bazel_re::GetActionResultRequest* request, ::bazel_re::ActionResult* response) -> ::grpc::Status { + if (auto error_msg = IsAHash(request->action_digest().hash()); error_msg) { + logger_.Emit(LogLevel::Debug, *error_msg); + return ::grpc::Status{::grpc::StatusCode::INVALID_ARGUMENT, *error_msg}; + } logger_.Emit(LogLevel::Trace, "GetActionResult: {}", request->action_digest().hash()); -- cgit v1.2.3