From 0d98a04c28eeb18d08f731c3f94de825d49daac5 Mon Sep 17 00:00:00 2001 From: Sascha Roloff Date: Fri, 23 Feb 2024 16:04:36 +0100 Subject: Implement blob splicing protocol at just server side --- .../execution_api/execution_service/cas_utils.cpp | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) (limited to 'src/buildtool/execution_api/execution_service/cas_utils.cpp') diff --git a/src/buildtool/execution_api/execution_service/cas_utils.cpp b/src/buildtool/execution_api/execution_service/cas_utils.cpp index 48bbd124..b710dd36 100644 --- a/src/buildtool/execution_api/execution_service/cas_utils.cpp +++ b/src/buildtool/execution_api/execution_service/cas_utils.cpp @@ -145,7 +145,8 @@ auto CASUtils::SplitBlobFastCDC(bazel_re::Digest const& blob_digest, auto CASUtils::SpliceBlob(bazel_re::Digest const& blob_digest, std::vector const& chunk_digests, - Storage const& storage) noexcept + Storage const& storage, + bool check_tree_invariant) noexcept -> std::variant { // Assemble blob from chunks. @@ -175,6 +176,20 @@ auto CASUtils::SpliceBlob(bazel_re::Digest const& blob_digest, // Store resulting blob in according CAS. auto const& hash = blob_digest.hash(); if (NativeSupport::IsTree(hash)) { + // In native mode: for trees, check whether the tree invariant holds + // before storing the actual tree object. + if (check_tree_invariant) { + auto tree_data = FileSystemManager::ReadFile(tmp_file); + if (not tree_data) { + return grpc::Status{ + grpc::StatusCode::INTERNAL, + fmt::format("could read tree data {}", hash)}; + } + if (auto err = EnsureTreeInvariant(*tree_data, hash, storage)) { + return grpc::Status{grpc::StatusCode::FAILED_PRECONDITION, + *err}; + } + } auto const& digest = storage.CAS().StoreTree(tmp_file); if (not digest) { -- cgit v1.2.3