From 74fbd57a3afabc04f594889e092cc735a1788346 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Wed, 31 Jul 2024 17:35:48 +0200 Subject: Remove ExecutionServiceImpl::StoreActionResult method ...and move the storing logic to Execute directly. There is no need to pass additional parameters to the method to just perform a check inside, and after this removal there is no need to preserve a one-line method. --- src/buildtool/execution_api/execution_service/execution_server.hpp | 7 ------- 1 file changed, 7 deletions(-) (limited to 'src/buildtool/execution_api/execution_service/execution_server.hpp') diff --git a/src/buildtool/execution_api/execution_service/execution_server.hpp b/src/buildtool/execution_api/execution_service/execution_server.hpp index 9ffaa9a7..f1337604 100644 --- a/src/buildtool/execution_api/execution_service/execution_server.hpp +++ b/src/buildtool/execution_api/execution_service/execution_server.hpp @@ -154,13 +154,6 @@ class ExecutionServiceImpl final : public bazel_re::Execution::Service { IExecutionResponse::Ptr const& i_execution_response) const noexcept -> expected<::bazel_re::ExecuteResponse, std::string>; - [[nodiscard]] auto StoreActionResult( - ::bazel_re::ExecuteRequest const* request, - IExecutionResponse::Ptr const& i_execution_response, - ::bazel_re::ExecuteResponse const& execute_response, - ::bazel_re::Action const& action) const noexcept - -> expected; - void WriteResponse( ::bazel_re::ExecuteResponse const& execute_response, ::grpc::ServerWriter<::google::longrunning::Operation>* writer, -- cgit v1.2.3