From 7a503a1c875e4c9ac4b014036da77983af5272bc Mon Sep 17 00:00:00 2001 From: Klaus Aehlig Date: Thu, 24 Aug 2023 11:43:05 +0200 Subject: Execution: only take complete actions from cache ... which are only actions that, besides giving exit code 0 also created all the outputs they promised to. --- src/buildtool/execution_api/local/local_action.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/buildtool/execution_api/local/local_action.cpp') diff --git a/src/buildtool/execution_api/local/local_action.cpp b/src/buildtool/execution_api/local/local_action.cpp index 3fcd8fe7..badc62e5 100644 --- a/src/buildtool/execution_api/local/local_action.cpp +++ b/src/buildtool/execution_api/local/local_action.cpp @@ -22,6 +22,7 @@ #include "src/buildtool/compatibility/native_support.hpp" #include "src/buildtool/execution_api/local/config.hpp" #include "src/buildtool/execution_api/local/local_response.hpp" +#include "src/buildtool/execution_api/utils/outputscheck.hpp" #include "src/buildtool/file_system/file_system_manager.hpp" #include "src/buildtool/file_system/object_type.hpp" #include "src/buildtool/storage/config.hpp" @@ -89,7 +90,9 @@ auto LocalAction::Execute(Logger const* logger) noexcept if (do_cache) { if (auto result = storage_->ActionCache().CachedResult(action)) { - if (result->exit_code() == 0) { + if (result->exit_code() == 0 and + ActionResultContainsExpectedOutputs( + *result, output_files_, output_dirs_)) { return IExecutionResponse::Ptr{ new LocalResponse{action.hash(), {std::move(*result), /*is_cached=*/true}, -- cgit v1.2.3