From f0ac970bac223f64e287d9b28f75b0d8da7de706 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Tue, 9 Jul 2024 15:28:37 +0200 Subject: Return std::nullopt if creation of an action digest fails ...instead of dereferencing nullptr. --- src/buildtool/execution_api/local/local_action.hpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/buildtool/execution_api/local/local_action.hpp') diff --git a/src/buildtool/execution_api/local/local_action.hpp b/src/buildtool/execution_api/local/local_action.hpp index 7999da33..582f9b8e 100644 --- a/src/buildtool/execution_api/local/local_action.hpp +++ b/src/buildtool/execution_api/local/local_action.hpp @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include // std::move @@ -97,7 +98,7 @@ class LocalAction final : public IExecutionAction { [[nodiscard]] auto CreateActionDigest(bazel_re::Digest const& exec_dir, bool do_not_cache) - -> bazel_re::Digest { + -> std::optional { auto const env_vars = BazelMsgFactory::CreateMessageVectorFromMap< bazel_re::Command_EnvironmentVariable>(env_vars_); -- cgit v1.2.3