From 33c576f9730da83752b2211efa4752c7f7d3d9af Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Tue, 24 Jun 2025 12:48:33 +0200 Subject: Clarify use of a clang-tidy check The google-default-arguments check normally imposes that virtual methods have no default arguments. For our use-cases, all implementations of such methods are expected to use the same default arguments, and thus this check is manually disabled via NOLINT comments. However, this is not done consistently. This commit cleans this up and clarifies our intent by: - removing the default values (and the NOLINT statement) for all implementations of virtual methods with default argument values, matching the desired intended behaviour, but - keeping the clang-tidy check for future cases where derived classes would want to provide each different defaults. --- src/buildtool/execution_api/local/local_api.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/buildtool/execution_api/local/local_api.cpp') diff --git a/src/buildtool/execution_api/local/local_api.cpp b/src/buildtool/execution_api/local/local_api.cpp index c0a3a30e..d746c8e9 100644 --- a/src/buildtool/execution_api/local/local_api.cpp +++ b/src/buildtool/execution_api/local/local_api.cpp @@ -59,7 +59,6 @@ LocalApi::LocalApi(gsl::not_null const& local_context, : local_context_{*local_context}, git_api_{CreateFallbackApi(*local_context->storage, repo_config)} {} -// NOLINTNEXTLINE(google-default-arguments) auto LocalApi::CreateAction( ArtifactDigest const& root_digest, std::vector const& command, @@ -102,7 +101,6 @@ auto LocalApi::CreateAction( properties}}; } -// NOLINTNEXTLINE(google-default-arguments) auto LocalApi::RetrieveToPaths( std::vector const& artifacts_info, std::vector const& output_paths, @@ -130,7 +128,6 @@ auto LocalApi::RetrieveToPaths( return true; } -// NOLINTNEXTLINE(google-default-arguments) auto LocalApi::RetrieveToFds( std::vector const& artifacts_info, std::vector const& fds, -- cgit v1.2.3