From 5b3ee91c84d37fe2cd7d4ddd9d26370447564161 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Thu, 20 Jun 2024 14:42:52 +0200 Subject: Mark IExecutionApi's methods constant --- src/buildtool/execution_api/local/local_api.hpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'src/buildtool/execution_api/local/local_api.hpp') diff --git a/src/buildtool/execution_api/local/local_api.hpp b/src/buildtool/execution_api/local/local_api.hpp index 035b14e9..fc64e842 100644 --- a/src/buildtool/execution_api/local/local_api.hpp +++ b/src/buildtool/execution_api/local/local_api.hpp @@ -57,13 +57,13 @@ class LocalApi final : public IExecutionApi { repo_config = std::nullopt) : repo_config_{std::move(repo_config)} {} - auto CreateAction( + [[nodiscard]] auto CreateAction( ArtifactDigest const& root_digest, std::vector const& command, std::vector const& output_files, std::vector const& output_dirs, std::map const& env_vars, - std::map const& properties) noexcept + std::map const& properties) const noexcept -> IExecutionAction::Ptr final { return IExecutionAction::Ptr{new LocalAction{storage_, root_digest, @@ -79,7 +79,7 @@ class LocalApi final : public IExecutionApi { std::vector const& artifacts_info, std::vector const& output_paths, std::optional> const& /*alternative*/ = - std::nullopt) noexcept -> bool final { + std::nullopt) const noexcept -> bool final { if (artifacts_info.size() != output_paths.size()) { Logger::Log(LogLevel::Error, "different number of digests and output paths."); @@ -143,7 +143,7 @@ class LocalApi final : public IExecutionApi { [[nodiscard]] auto RetrieveToFds( std::vector const& artifacts_info, std::vector const& fds, - bool raw_tree) noexcept -> bool final { + bool raw_tree) const noexcept -> bool final { auto dumper = StreamDumper{storage_->CAS()}; return CommonRetrieveToFds( artifacts_info, @@ -171,7 +171,7 @@ class LocalApi final : public IExecutionApi { // NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto RetrieveToCas( std::vector const& artifacts_info, - gsl::not_null const& api) noexcept -> bool final { + gsl::not_null const& api) const noexcept -> bool final { // Return immediately if target CAS is this CAS if (this == api) { @@ -249,7 +249,7 @@ class LocalApi final : public IExecutionApi { } [[nodiscard]] auto RetrieveToMemory( - Artifact::ObjectInfo const& artifact_info) noexcept + Artifact::ObjectInfo const& artifact_info) const noexcept -> std::optional override { std::optional location{}; if (IsTreeObject(artifact_info.type)) { @@ -271,7 +271,7 @@ class LocalApi final : public IExecutionApi { } [[nodiscard]] auto Upload(ArtifactBlobContainer&& blobs, - bool /*skip_find_missing*/) noexcept + bool /*skip_find_missing*/) const noexcept -> bool final { for (auto const& blob : blobs.Blobs()) { auto const is_tree = NativeSupport::IsTree( @@ -288,8 +288,8 @@ class LocalApi final : public IExecutionApi { } [[nodiscard]] auto UploadTree( - std::vector const& - artifacts) noexcept -> std::optional final { + std::vector const& artifacts) + const noexcept -> std::optional final { auto build_root = DirectoryTree::FromNamedArtifacts(artifacts); if (not build_root) { Logger::Log(LogLevel::Debug, -- cgit v1.2.3