From 7a503a1c875e4c9ac4b014036da77983af5272bc Mon Sep 17 00:00:00 2001 From: Klaus Aehlig Date: Thu, 24 Aug 2023 11:43:05 +0200 Subject: Execution: only take complete actions from cache ... which are only actions that, besides giving exit code 0 also created all the outputs they promised to. --- src/buildtool/execution_api/remote/bazel/bazel_action.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'src/buildtool/execution_api/remote/bazel/bazel_action.cpp') diff --git a/src/buildtool/execution_api/remote/bazel/bazel_action.cpp b/src/buildtool/execution_api/remote/bazel/bazel_action.cpp index 04d4c3f7..65dfd083 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_action.cpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_action.cpp @@ -17,6 +17,7 @@ #include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp" #include "src/buildtool/execution_api/bazel_msg/bazel_msg_factory.hpp" #include "src/buildtool/execution_api/remote/bazel/bazel_response.hpp" +#include "src/buildtool/execution_api/utils/outputscheck.hpp" BazelAction::BazelAction( std::shared_ptr network, @@ -57,7 +58,11 @@ auto BazelAction::Execute(Logger const* logger) noexcept if (do_cache) { if (auto result = network_->GetCachedActionResult(action, output_files_)) { - if (result->exit_code() == 0) { + if (result->exit_code() == 0 and + ActionResultContainsExpectedOutputs( + *result, output_files_, output_dirs_) + + ) { return IExecutionResponse::Ptr{new BazelResponse{ action.hash(), network_, {*result, true}}}; } -- cgit v1.2.3