From 59a0ce6d9df4465f2a7e6cbeb78a339f30574ae6 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Mon, 16 Sep 2024 15:31:15 +0200 Subject: Small code improvements based on lint warnings - add more noexcept requirements and enforce existing - fixing inconsistencies related to function arguments - remove redundant static keywords - silencing excessive lint reporting in test cases While there, make more getters const ref. --- src/buildtool/execution_api/remote/bazel/bazel_api.cpp | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to 'src/buildtool/execution_api/remote/bazel/bazel_api.cpp') diff --git a/src/buildtool/execution_api/remote/bazel/bazel_api.cpp b/src/buildtool/execution_api/remote/bazel/bazel_api.cpp index 07c5c3ef..e42c32e7 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_api.cpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_api.cpp @@ -386,11 +386,19 @@ auto BazelApi::CreateAction( gsl::not_null*> done) const noexcept -> bool { std::unordered_set artifacts_info; - artifacts_info.reserve(all_artifacts_info.size()); - for (auto const& info : all_artifacts_info) { - if (not done->contains(info)) { - artifacts_info.insert(info); + try { + artifacts_info.reserve(all_artifacts_info.size()); + for (auto const& info : all_artifacts_info) { + if (not done->contains(info)) { + artifacts_info.emplace(info); + } } + } catch (std::exception const& ex) { + Logger::Log( + LogLevel::Error, + "BazelApi: Collecting the set of artifacts failed with:\n{}", + ex.what()); + return false; } if (artifacts_info.empty()) { return true; // Nothing to do -- cgit v1.2.3