From 60a0f3c2fde2064c3ba64add08dae8fbf6c5930b Mon Sep 17 00:00:00 2001 From: Klaus Aehlig Date: Mon, 2 Jun 2025 11:42:14 +0200 Subject: ParallelRetrieveToCasWithCache: abort early on failure ... and do mark artifacts internally as synchronized. First all all, we will abort anyway, to the entry won't even be read and, secondly it is not necessarily true that the artifact is synchronized. (cherry-picked from d1dc5cce32ba20c0dae13aecf63e88fe8ead899f) --- src/buildtool/execution_api/remote/bazel/bazel_api.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/buildtool/execution_api/remote/bazel/bazel_api.cpp') diff --git a/src/buildtool/execution_api/remote/bazel/bazel_api.cpp b/src/buildtool/execution_api/remote/bazel/bazel_api.cpp index eb140b3c..78231494 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_api.cpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_api.cpp @@ -473,6 +473,10 @@ auto BazelApi::CreateAction( return false; } + if (failure) { + return false; + } + try { for (auto const& info : artifacts_info) { done->insert(info); @@ -484,7 +488,7 @@ auto BazelApi::CreateAction( ex.what()); } - return not failure; + return true; } [[nodiscard]] auto BazelApi::RetrieveToMemory( -- cgit v1.2.3