From 73c00a4820097588c2dc0bd9a89d34a65de0084b Mon Sep 17 00:00:00 2001 From: Alberto Sartori Date: Wed, 15 Mar 2023 12:51:16 +0100 Subject: bazel client: remove BazelAcClient::UpdateActionResult... ...both buildbarn and just execute do not allow a direct upload to the action cache. Moreover, our tool does not support it, anyway, meaning it was dead code. --- .../execution_api/remote/bazel/bazel_ac_client.cpp | 28 ---------------------- .../execution_api/remote/bazel/bazel_ac_client.hpp | 6 ----- 2 files changed, 34 deletions(-) (limited to 'src/buildtool/execution_api/remote/bazel') diff --git a/src/buildtool/execution_api/remote/bazel/bazel_ac_client.cpp b/src/buildtool/execution_api/remote/bazel/bazel_ac_client.cpp index 6eac5adf..74542453 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_ac_client.cpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_ac_client.cpp @@ -56,31 +56,3 @@ auto BazelAcClient::GetActionResult( } return response; } - -auto BazelAcClient::UpdateActionResult(std::string const& instance_name, - bazel_re::Digest const& action_digest, - bazel_re::ActionResult const& result, - int priority) noexcept - -> std::optional { - auto policy = std::make_unique(); - policy->set_priority(priority); - - bazel_re::UpdateActionResultRequest request{}; - request.set_instance_name(instance_name); - request.set_allocated_action_digest( - gsl::owner{new bazel_re::Digest{action_digest}}); - request.set_allocated_action_result(gsl::owner{ - new bazel_re::ActionResult{result}}); - request.set_allocated_results_cache_policy(policy.release()); - - grpc::ClientContext context; - bazel_re::ActionResult response; - grpc::Status status = - stub_->UpdateActionResult(&context, request, &response); - - if (not status.ok()) { - LogStatus(&logger_, LogLevel::Debug, status); - return std::nullopt; - } - return response; -} diff --git a/src/buildtool/execution_api/remote/bazel/bazel_ac_client.hpp b/src/buildtool/execution_api/remote/bazel/bazel_ac_client.hpp index fd0e79cb..99c28412 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_ac_client.hpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_ac_client.hpp @@ -39,12 +39,6 @@ class BazelAcClient { std::vector const& inline_output_files) noexcept -> std::optional; - [[nodiscard]] auto UpdateActionResult(std::string const& instance_name, - bazel_re::Digest const& digest, - bazel_re::ActionResult const& result, - int priority) noexcept - -> std::optional; - private: std::unique_ptr stub_; Logger logger_{"RemoteAcClient"}; -- cgit v1.2.3