From 4582c6cb76f4fc7f49025969aba7f8a29a797d64 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Fri, 13 Sep 2024 10:59:52 +0200 Subject: Fix assignments in conditions ...proposed by clang-tidy. Enable bugprone-assignment-in-if-condition check. --- src/buildtool/execution_api/remote/config.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/buildtool/execution_api/remote/config.cpp') diff --git a/src/buildtool/execution_api/remote/config.cpp b/src/buildtool/execution_api/remote/config.cpp index 7f065296..c2832c1b 100644 --- a/src/buildtool/execution_api/remote/config.cpp +++ b/src/buildtool/execution_api/remote/config.cpp @@ -32,7 +32,8 @@ auto RemoteExecutionConfig::Builder::Build() const noexcept // Set remote endpoint. auto remote_address = default_config.remote_address; if (remote_address_raw_.has_value()) { - if (not(remote_address = ParseAddress(*remote_address_raw_))) { + remote_address = ParseAddress(*remote_address_raw_); + if (not remote_address) { return unexpected{ fmt::format("Failed to set remote endpoint address {}", nlohmann::json(*remote_address_raw_).dump())}; -- cgit v1.2.3