From 0fc0d9118b5e525fa582de0286c8e83bb0da4e16 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Fri, 4 Oct 2024 14:42:28 +0200 Subject: Disable misc-no-recursion check ...since we use recursion for trees a lot, but skip this check manually. --- src/buildtool/execution_api/remote/bazel/bazel_api.cpp | 4 +--- src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) (limited to 'src/buildtool/execution_api/remote') diff --git a/src/buildtool/execution_api/remote/bazel/bazel_api.cpp b/src/buildtool/execution_api/remote/bazel/bazel_api.cpp index 1b2933af..c9206d1b 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_api.cpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_api.cpp @@ -230,7 +230,7 @@ auto BazelApi::CreateAction( properties}}; } -// NOLINTNEXTLINE(misc-no-recursion, google-default-arguments) +// NOLINTNEXTLINE(google-default-arguments) [[nodiscard]] auto BazelApi::RetrieveToPaths( std::vector const& artifacts_info, std::vector const& output_paths, @@ -323,7 +323,6 @@ auto BazelApi::CreateAction( ); } -// NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto BazelApi::RetrieveToCas( std::vector const& artifacts_info, IExecutionApi const& api) const noexcept -> bool { @@ -382,7 +381,6 @@ auto BazelApi::CreateAction( artifacts_info, api, jobs, use_blob_splitting, &done); } -/// NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto BazelApi::ParallelRetrieveToCasWithCache( std::vector const& all_artifacts_info, IExecutionApi const& api, diff --git a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp index 91498b22..e4ce1ce0 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp @@ -263,7 +263,6 @@ auto BazelCasClient::BatchReadBlobs( return result; } -// NOLINTNEXTLINE(misc-no-recursion) auto BazelCasClient::GetTree(std::string const& instance_name, bazel_re::Digest const& root_digest, std::int32_t page_size, @@ -484,7 +483,6 @@ auto BazelCasClient::FindMissingBlobs(std::string const& instance_name, return result; } -// NOLINTNEXTLINE(misc-no-recursion) auto BazelCasClient::BatchUpdateBlobs( std::string const& instance_name, std::vector>::const_iterator const& begin, -- cgit v1.2.3