From 33c576f9730da83752b2211efa4752c7f7d3d9af Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Tue, 24 Jun 2025 12:48:33 +0200 Subject: Clarify use of a clang-tidy check The google-default-arguments check normally imposes that virtual methods have no default arguments. For our use-cases, all implementations of such methods are expected to use the same default arguments, and thus this check is manually disabled via NOLINT comments. However, this is not done consistently. This commit cleans this up and clarifies our intent by: - removing the default values (and the NOLINT statement) for all implementations of virtual methods with default argument values, matching the desired intended behaviour, but - keeping the clang-tidy check for future cases where derived classes would want to provide each different defaults. --- src/buildtool/execution_api/serve/mr_local_api.hpp | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) (limited to 'src/buildtool/execution_api/serve/mr_local_api.hpp') diff --git a/src/buildtool/execution_api/serve/mr_local_api.hpp b/src/buildtool/execution_api/serve/mr_local_api.hpp index 738f52fe..237c1267 100644 --- a/src/buildtool/execution_api/serve/mr_local_api.hpp +++ b/src/buildtool/execution_api/serve/mr_local_api.hpp @@ -65,20 +65,16 @@ class MRLocalApi final : public IExecutionApi { /// Handles both native and compatible artifacts. Dispatches to appropriate /// local api instance based on digest hash type. Alternative api is never /// used. - // NOLINTNEXTLINE(google-default-arguments) [[nodiscard]] auto RetrieveToPaths( std::vector const& artifacts_info, std::vector const& output_paths, - IExecutionApi const* /*alternative*/ = nullptr) const noexcept - -> bool final; + IExecutionApi const* /*alternative*/) const noexcept -> bool final; - // NOLINTNEXTLINE(google-default-arguments) [[nodiscard]] auto RetrieveToFds( std::vector const& /*artifacts_info*/, std::vector const& /*fds*/, bool /*raw_tree*/, - IExecutionApi const* /*alternative*/ = nullptr) const noexcept - -> bool final { + IExecutionApi const* /*alternative*/) const noexcept -> bool final { // Retrieval to file descriptors not supported return false; } @@ -104,9 +100,8 @@ class MRLocalApi final : public IExecutionApi { /// the blobs to the appropriate local api instance based on used protocol. /// \note Caller is responsible for passing vectors with artifacts of the /// same digest type. - // NOLINTNEXTLINE(google-default-arguments) [[nodiscard]] auto Upload(std::unordered_set&& blobs, - bool skip_find_missing = false) const noexcept + bool skip_find_missing) const noexcept -> bool final; [[nodiscard]] auto UploadTree( -- cgit v1.2.3