From 477c7d5e496b8eb5113b3b51f7152e05eae51fd7 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Thu, 30 Jan 2025 15:18:35 +0100 Subject: IExecutionApi: Rename IsAvailable to GetMissingDigests --- src/buildtool/execution_api/serve/mr_git_api.hpp | 2 +- src/buildtool/execution_api/serve/mr_local_api.cpp | 9 +++++---- src/buildtool/execution_api/serve/mr_local_api.hpp | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) (limited to 'src/buildtool/execution_api/serve') diff --git a/src/buildtool/execution_api/serve/mr_git_api.hpp b/src/buildtool/execution_api/serve/mr_git_api.hpp index b03bfcf1..dbcedb61 100644 --- a/src/buildtool/execution_api/serve/mr_git_api.hpp +++ b/src/buildtool/execution_api/serve/mr_git_api.hpp @@ -123,7 +123,7 @@ class MRGitApi final : public IExecutionApi { } /// \brief Not implemented. - [[nodiscard]] auto IsAvailable( + [[nodiscard]] auto GetMissingDigests( std::unordered_set const& /*digests*/) const noexcept -> std::unordered_set final { // Not supported. diff --git a/src/buildtool/execution_api/serve/mr_local_api.cpp b/src/buildtool/execution_api/serve/mr_local_api.cpp index 5449b245..0e2f61e1 100644 --- a/src/buildtool/execution_api/serve/mr_local_api.cpp +++ b/src/buildtool/execution_api/serve/mr_local_api.cpp @@ -124,8 +124,9 @@ auto MRLocalApi::IsAvailable(ArtifactDigest const& digest) const noexcept return compat_local_api_->IsAvailable(digest); } -auto MRLocalApi::IsAvailable(std::unordered_set const& digests) - const noexcept -> std::unordered_set { +auto MRLocalApi::GetMissingDigests( + std::unordered_set const& digests) const noexcept + -> std::unordered_set { // This method can legitimately be called with both native and // compatible digests when in compatible mode, therefore we need to // interrogate the hash type of the input. @@ -136,7 +137,7 @@ auto MRLocalApi::IsAvailable(std::unordered_set const& digests) } // native digests get dispatched to native local api if (ProtocolTraits::IsNative(digests.begin()->GetHashType())) { - return native_local_api_->IsAvailable(digests); + return native_local_api_->GetMissingDigests(digests); } // compatible digests get dispatched to compatible local api if (compat_local_api_ == nullptr) { @@ -144,5 +145,5 @@ auto MRLocalApi::IsAvailable(std::unordered_set const& digests) "MRLocalApi: Unexpected digest type provided"); return {}; } - return compat_local_api_->IsAvailable(digests); + return compat_local_api_->GetMissingDigests(digests); } diff --git a/src/buildtool/execution_api/serve/mr_local_api.hpp b/src/buildtool/execution_api/serve/mr_local_api.hpp index c548241e..a4f6e0b1 100644 --- a/src/buildtool/execution_api/serve/mr_local_api.hpp +++ b/src/buildtool/execution_api/serve/mr_local_api.hpp @@ -126,7 +126,7 @@ class MRLocalApi final : public IExecutionApi { /// \note The caller is responsible for passing vectors with digests of the /// same type. For simplicity, this method takes the first digest of the /// vector as representative for figuring out hash function type. - [[nodiscard]] auto IsAvailable( + [[nodiscard]] auto GetMissingDigests( std::unordered_set const& digests) const noexcept -> std::unordered_set final; -- cgit v1.2.3