From 51b650e404bf4ff06a0751275fc6fc74ddb23bfd Mon Sep 17 00:00:00 2001 From: Klaus Aehlig Date: Wed, 12 Feb 2025 17:29:50 +0100 Subject: BatchReadBlob: fix error reporting The WithRetry function returns true upon success; therefore a failure occured if the negation of the value is true. We should report an error only in case of failure. --- src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/buildtool/execution_api') diff --git a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp index 8384cdac..e5392c7d 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp @@ -307,7 +307,7 @@ auto BazelCasClient::BatchReadBlobs( }, retry_config_, logger_); - has_failure = has_failure or retry_result; + has_failure = has_failure or not retry_result; } if (has_failure) { logger_.Emit(LogLevel::Error, "Failed to BatchReadBlobs."); -- cgit v1.2.3