From 59a0ce6d9df4465f2a7e6cbeb78a339f30574ae6 Mon Sep 17 00:00:00 2001
From: Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com>
Date: Mon, 16 Sep 2024 15:31:15 +0200
Subject: Small code improvements based on lint warnings

- add more noexcept requirements and enforce existing
- fixing inconsistencies related to function arguments
- remove redundant static keywords
- silencing excessive lint reporting in test cases

While there, make more getters const ref.
---
 src/buildtool/execution_engine/dag/dag.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/buildtool/execution_engine/dag/dag.cpp')

diff --git a/src/buildtool/execution_engine/dag/dag.cpp b/src/buildtool/execution_engine/dag/dag.cpp
index 17f4b3af..cb82ec55 100644
--- a/src/buildtool/execution_engine/dag/dag.cpp
+++ b/src/buildtool/execution_engine/dag/dag.cpp
@@ -148,7 +148,7 @@ auto DependencyGraph::AddAction(ActionDescription const& description) -> bool {
 
 auto DependencyGraph::AddAction(Action const& a) noexcept
     -> DependencyGraph::ActionNodeIdentifier {
-    auto id = a.Id();
+    auto const& id = a.Id();
     auto const action_it = action_ids_.find(id);
     if (action_it != action_ids_.end()) {
         return action_it->second;
-- 
cgit v1.2.3