From 0bf658d28ed15fb7c37d588ad27cdd8a6a481d2e Mon Sep 17 00:00:00 2001 From: Klaus Aehlig Date: Tue, 26 Apr 2022 14:58:42 +0200 Subject: Rebuild: report full command line With the reformating of the analyse result we accepted longer output lines anyway. Allowing them in the report of a detected flaky action immediately gets the log and console output more useful, as the source can often be identified without looking at the full definition of the action in the action graph. --- src/buildtool/execution_engine/executor/executor.hpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/buildtool/execution_engine/executor/executor.hpp') diff --git a/src/buildtool/execution_engine/executor/executor.hpp b/src/buildtool/execution_engine/executor/executor.hpp index 9ef38488..02caf6c5 100644 --- a/src/buildtool/execution_engine/executor/executor.hpp +++ b/src/buildtool/execution_engine/executor/executor.hpp @@ -552,13 +552,11 @@ class Rebuilder { auto const& action_id = action.Id(); if (msg->tellp() <= 0) { bool tainted = action.MayFail() or action.NoCache(); - static constexpr auto kMaxCmdChars = 69; // 80 - (prefix + suffix) auto cmd = GetCmdString(action); (*msg) << "Found flaky " << (tainted ? "tainted " : "") << "action:" << std::endl << " - id: " << action_id << std::endl - << " - cmd: " << cmd.substr(0, kMaxCmdChars) - << (cmd.length() > kMaxCmdChars ? "..." : "") << std::endl; + << " - cmd: " << cmd << std::endl; } (*msg) << " - output '" << path << "' differs:" << std::endl << " - " << rebuilt.ToString() << " (rebuilt)" << std::endl -- cgit v1.2.3