From 74f53b444853850144c3e63593f83c424e84a768 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Thu, 4 Jul 2024 11:21:11 +0200 Subject: Mark more constructors 'explicit' Since c++17 the 'explicit' keyword has use also for constructors with more than one argument and it is recommended to use it by default whereever implicit conversions are not expected bahaviour. --- src/buildtool/execution_engine/traverser/traverser.hpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/buildtool/execution_engine/traverser/traverser.hpp') diff --git a/src/buildtool/execution_engine/traverser/traverser.hpp b/src/buildtool/execution_engine/traverser/traverser.hpp index 81f2e348..e99c2565 100644 --- a/src/buildtool/execution_engine/traverser/traverser.hpp +++ b/src/buildtool/execution_engine/traverser/traverser.hpp @@ -46,10 +46,10 @@ concept Runnable = requires(T const r, template class Traverser { public: - Traverser(Executor const& r, - DependencyGraph const& graph, - std::size_t jobs, - gsl::not_null*> const& fail_flag) + explicit Traverser(Executor const& r, + DependencyGraph const& graph, + std::size_t jobs, + gsl::not_null*> const& fail_flag) : runner_{r}, graph_{graph}, failed_{fail_flag}, tasker_{jobs} {} Traverser() = delete; Traverser(Traverser const&) = delete; -- cgit v1.2.3