From 0374b80dd407d7b35654a01e3c7526b749d3464e Mon Sep 17 00:00:00 2001
From: Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com>
Date: Fri, 23 Dec 2022 17:18:42 +0100
Subject: Just-MR: Remove wrong pass-by-reference when wrapping loggers

Passing the logger by reference would require the caller to be
kept alive. Also, being a shared_ptr, the logger can be passed
by value at almost no cost.
---
 src/buildtool/file_system/git_repo.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'src/buildtool/file_system/git_repo.cpp')

diff --git a/src/buildtool/file_system/git_repo.cpp b/src/buildtool/file_system/git_repo.cpp
index e51c404e..7a4915a3 100644
--- a/src/buildtool/file_system/git_repo.cpp
+++ b/src/buildtool/file_system/git_repo.cpp
@@ -1082,7 +1082,7 @@ auto GitRepo::GetSubtreeFromPath(std::filesystem::path const& fpath,
         }
         // setup wrapped logger
         auto wrapped_logger = std::make_shared<anon_logger_t>(
-            [&logger](auto const& msg, bool fatal) {
+            [logger](auto const& msg, bool fatal) {
                 (*logger)(
                     fmt::format("While getting repo root from path:\n{}", msg),
                     fatal);
@@ -1095,7 +1095,7 @@ auto GitRepo::GetSubtreeFromPath(std::filesystem::path const& fpath,
 
         // setup wrapped logger
         wrapped_logger = std::make_shared<anon_logger_t>(
-            [&logger](auto const& msg, bool fatal) {
+            [logger](auto const& msg, bool fatal) {
                 (*logger)(fmt::format("While going subtree hash retrieval from "
                                       "path:\n{}",
                                       msg),
@@ -1182,7 +1182,7 @@ auto GitRepo::UpdateCommitViaTmpRepo(std::filesystem::path const& tmp_repo_path,
         }
         // setup wrapped logger
         auto wrapped_logger = std::make_shared<anon_logger_t>(
-            [&logger](auto const& msg, bool fatal) {
+            [logger](auto const& msg, bool fatal) {
                 (*logger)(
                     fmt::format("While doing commit update via tmp repo:\n{}",
                                 msg),
@@ -1228,7 +1228,7 @@ auto GitRepo::FetchViaTmpRepo(std::filesystem::path const& tmp_repo_path,
                 std::numeric_limits<int>::max()) == 0) {
             // setup wrapped logger
             auto wrapped_logger = std::make_shared<anon_logger_t>(
-                [&logger](auto const& msg, bool fatal) {
+                [logger](auto const& msg, bool fatal) {
                     (*logger)(
                         fmt::format(
                             "While doing branch fetch via tmp repo:\n{}", msg),
-- 
cgit v1.2.3