From cc5636adb95d6e0de1ff7858b317d7ed319c0ee8 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Tue, 4 Jul 2023 16:13:30 +0200 Subject: Git: Fix handling of symlinks in tree artifacts The introduction of non-upwards symlinks as first-class objects should have updated the handling of known git tree artifacts containing symlinks. In particular, one should consider trees in their entirety when uploading (irrespective of the ignore_special flag), and git trees should only be reported as known only if the ignore_special flag is set to false. --- src/buildtool/file_system/git_repo.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/buildtool/file_system/git_repo.cpp') diff --git a/src/buildtool/file_system/git_repo.cpp b/src/buildtool/file_system/git_repo.cpp index 4dbbca39..bb60c68b 100644 --- a/src/buildtool/file_system/git_repo.cpp +++ b/src/buildtool/file_system/git_repo.cpp @@ -149,7 +149,9 @@ std::unordered_set const kNonSpecialGitFileModes{ return 1; // return >=0 on success, 1 == skip subtrees (flat) } } - Logger::Log(LogLevel::Error, "failed walk for git tree entry: {}", name); + Logger::Log(LogLevel::Error, + "failed ignore_special walk for git tree entry: {}", + name); return -1; // fail } -- cgit v1.2.3