From c7dac3f368213238b752cf394f025de3c94df241 Mon Sep 17 00:00:00 2001 From: Klaus Aehlig Date: Thu, 18 Jul 2024 12:45:39 +0200 Subject: git_repo: return keep tags on success ... instead of the plain boolean value. --- src/buildtool/file_system/git_repo.hpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'src/buildtool/file_system/git_repo.hpp') diff --git a/src/buildtool/file_system/git_repo.hpp b/src/buildtool/file_system/git_repo.hpp index 2a4a4238..95fa14a6 100644 --- a/src/buildtool/file_system/git_repo.hpp +++ b/src/buildtool/file_system/git_repo.hpp @@ -159,11 +159,12 @@ class GitRepo { /// \brief Create annotated tag for given commit. /// Only possible with real repository and thus non-thread-safe. - /// Returns success flag. + /// Returns the tag on success. /// It guarantees the logger is called exactly once with fatal if failure. [[nodiscard]] auto KeepTag(std::string const& commit, std::string const& message, - anon_logger_ptr const& logger) noexcept -> bool; + anon_logger_ptr const& logger) noexcept + -> std::optional; /// \brief Retrieves the commit of the HEAD reference. /// Only possible with real repository and thus non-thread-safe. @@ -188,11 +189,12 @@ class GitRepo { /// \brief Ensure given tree is kept alive via a tag. It is expected that /// the tree is part of the repository already. /// Only possible with real repository and thus non-thread-safe. - /// Returns success flag. + /// Returns the tag on success. /// It guarantees the logger is called exactly once with fatal if failure. [[nodiscard]] auto KeepTree(std::string const& tree_id, std::string const& message, - anon_logger_ptr const& logger) noexcept -> bool; + anon_logger_ptr const& logger) noexcept + -> std::optional; /// \brief Get the tree id of a subtree given the root commit /// Calling it from a fake repository allows thread-safe use. -- cgit v1.2.3