From 4582c6cb76f4fc7f49025969aba7f8a29a797d64 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Fri, 13 Sep 2024 10:59:52 +0200 Subject: Fix assignments in conditions ...proposed by clang-tidy. Enable bugprone-assignment-in-if-condition check. --- src/buildtool/file_system/git_utils.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/buildtool/file_system/git_utils.cpp') diff --git a/src/buildtool/file_system/git_utils.cpp b/src/buildtool/file_system/git_utils.cpp index 8fed7d7b..d9833521 100644 --- a/src/buildtool/file_system/git_utils.cpp +++ b/src/buildtool/file_system/git_utils.cpp @@ -32,8 +32,8 @@ constexpr std::size_t kOIDHexSize{GIT_OID_HEXSZ}; auto GitLastError() noexcept -> std::string { #ifndef BOOTSTRAP_BUILD_TOOL - git_error const* err{nullptr}; - if ((err = git_error_last()) != nullptr and err->message != nullptr) { + git_error const* const err = git_error_last(); + if (err != nullptr and err->message != nullptr) { return fmt::format("error code {}: {}", err->klass, err->message); } #endif // BOOTSTRAP_BUILD_TOOL -- cgit v1.2.3