From 87eb89d8d3b28d7e9da26199654ec3be8ee59565 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Mon, 11 Mar 2024 16:52:52 +0100 Subject: just serve: Improve progress reporting During analysis it is useful to track and report the progress for all export targets. This is not exclusively linked to a serve endpoint being present, despite most of the time being expected to be spent in export targets being served from the remote endpoint. This commit refactors the current implementation to give proper feedback to the user on the progress of the analysis phase. --- .../serve_api/progress_reporting/statistics.hpp | 55 ---------------------- 1 file changed, 55 deletions(-) delete mode 100644 src/buildtool/serve_api/progress_reporting/statistics.hpp (limited to 'src/buildtool/serve_api/progress_reporting/statistics.hpp') diff --git a/src/buildtool/serve_api/progress_reporting/statistics.hpp b/src/buildtool/serve_api/progress_reporting/statistics.hpp deleted file mode 100644 index 6c1aa352..00000000 --- a/src/buildtool/serve_api/progress_reporting/statistics.hpp +++ /dev/null @@ -1,55 +0,0 @@ -// Copyright 2023 Huawei Cloud Computing Technology Co., Ltd. -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -#ifndef INCLUDED_SRC_BUILDTOOL_SERVE_API_PROGRESS_REPORTING_STATISTICS_HPP -#define INCLUDED_SRC_BUILDTOOL_SERVE_API_PROGRESS_REPORTING_STATISTICS_HPP - -#include - -class ServeServiceStatistics { - public: - [[nodiscard]] static auto Instance() noexcept -> ServeServiceStatistics& { - static ServeServiceStatistics instance{}; - return instance; - } - - void Reset() noexcept { - num_cache_hits_ = 0; - num_dispatched_ = 0; - num_served_ = 0; - } - void IncrementCacheHitsCounter() noexcept { ++num_cache_hits_; } - void IncrementDispatchedCounter() noexcept { ++num_dispatched_; } - void IncrementServedCounter() noexcept { ++num_served_; } - - [[nodiscard]] auto CacheHitsCounter() const noexcept -> int { - return num_cache_hits_; - } - [[nodiscard]] auto DispatchedCounter() const noexcept -> int { - return num_dispatched_; - } - [[nodiscard]] auto ServedCounter() const noexcept -> int { - return num_served_; - } - - private: - // locally cached export targets - std::atomic num_cache_hits_{}; - // export targets for which we have queried just serve - std::atomic num_dispatched_{}; - // export targets for which just serve responded - std::atomic num_served_{}; -}; - -#endif // INCLUDED_SRC_BUILDTOOL_SERVE_API_PROGRESS_REPORTING_STATISTICS_HPP -- cgit v1.2.3