From 47eeba4a4a7302662f4c39ebcc8e15a7876f8227 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Mon, 9 Oct 2023 15:30:31 +0200 Subject: just serve: Fix inconsistencies - add missing serve_api TARGETS file - rename service client to align with server naming scheme - fix inconsistencies in comments between implementation and protocol --- src/buildtool/serve_api/serve_service/source_tree.hpp | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) (limited to 'src/buildtool/serve_api/serve_service/source_tree.hpp') diff --git a/src/buildtool/serve_api/serve_service/source_tree.hpp b/src/buildtool/serve_api/serve_service/source_tree.hpp index 089844a1..a74de455 100644 --- a/src/buildtool/serve_api/serve_service/source_tree.hpp +++ b/src/buildtool/serve_api/serve_service/source_tree.hpp @@ -33,15 +33,9 @@ class SourceTreeService final : public justbuild::just_serve::SourceTree::Service { public: - // Retrieve the tree of a commit. + // Retrieve the Git-subtree identifier from a given Git commit. // - // This request interrogates the service whether it knows a given Git - // commit. If requested commit is found, it provides the commit's - // Git-tree identifier. - // - // Errors: - // - // * `NOT_FOUND`: The requested commit could not be found. + // There are no method-specific errors. auto ServeCommitTree( ::grpc::ServerContext* context, const ::justbuild::just_serve::ServeCommitTreeRequest* request, @@ -58,11 +52,11 @@ class SourceTreeService final gsl::not_null const local_api_{ CreateExecutionApi(std::nullopt)}; - [[nodiscard]] static auto GetTreeFromCommit( + [[nodiscard]] static auto GetSubtreeFromCommit( std::filesystem::path const& repo_path, std::string const& commit, std::string const& subdir, std::shared_ptr const& logger) -> std::optional; }; -#endif +#endif // INCLUDED_SRC_BUILDTOOL_SERVE_API_SERVE_SERVICE_SOURCE_TREE_HPP -- cgit v1.2.3